From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753854AbcGLMnQ (ORCPT ); Tue, 12 Jul 2016 08:43:16 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34072 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753321AbcGLMnN (ORCPT ); Tue, 12 Jul 2016 08:43:13 -0400 Date: Tue, 12 Jul 2016 14:43:09 +0200 From: Daniel Vetter To: Lothar =?iso-8859-1?Q?Wa=DFmann?= Cc: David Airlie , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 1/1] drm/imx: convey the pixelclk-active and de-active flags from DT to the ipu-di driver Message-ID: <20160712124309.GV23520@phenom.ffwll.local> Mail-Followup-To: Lothar =?iso-8859-1?Q?Wa=DFmann?= , David Airlie , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1464182296-23812-1-git-send-email-LW@KARO-electronics.de> <20160712135428.4a348a06@ipc1.ka-ro> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160712135428.4a348a06@ipc1.ka-ro> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2016 at 01:54:28PM +0200, Lothar Waßmann wrote: > Hi, > > On Wed, 25 May 2016 15:18:16 +0200 Lothar Waßmann wrote: > > The 'de-active' and 'pixelclk-active' DT properties are evaluated > > by of_parse_display_timing() called from of_get_drm_display_mode(), > > but later lost in the conversion from videomode.flags to > > drm_display_mode.flags. > > Use an open coded version of of_get_drm_display_mode() to get access > > to these flags and make sure they are passed on to the ipu-di driver. > > > > Changes vs. v2: > > - removed patches which have already been applied > > - created a drm_bus_flags_from_videomode() helper to prevent code > > duplication as suggested by Philipp Zabel > > > > Changes vs. v1: > > - rebased on top of https://patchwork.kernel.org/patch/9113791/ as > > per Philipp Zabel's request > > > > GIT: [PATCHv2 1/3] drm/imx: imx-ldb: honor 'native-mode' property when > > GIT: [PATCHv2 2/3] drm/imx: convey the pixelclk-active and de-active flags > > GIT: [PATCHv2 3/3] drm/imx: remove dead code Should this be split up into 3 patches? At least it's good practice to split up the drm core helper functions into it's own patch, instead of hiding it behind something with the drm/imx prefix - no one will spot it that way. > Ping?! If imx maintainers keep being asleep at the helm I can merge this through drm-misc, but I'd like some more tested-by from other folks if possible. Even better when there's a review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch