From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1030249AbcGLMpJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jul 2016 08:45:09 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:36383 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751179AbcGLMpG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jul 2016 08:45:06 -0400
Date: Tue, 12 Jul 2016 14:45:01 +0200
From: Daniel Vetter <daniel@ffwll.ch>
To: Tejun Heo <tj@kernel.org>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
        Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
        Alex Deucher <alexander.deucher@amd.com>,
        Sinclair Yeh <syeh@vmware.com>,
        Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Jonathon Jongsma <jjongsma@redhat.com>,
        Jani Nikula <jani.nikula@intel.com>, John Keeping <john@metanate.com>,
        Ville =?iso-8859-1?Q?Syrj=E4l=E4?= 
	<ville.syrjala@linux.intel.com>,
        Noralf =?iso-8859-1?Q?Tr=F8nnes?= <noralf@tronnes.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/qxl: Remove deprecated create_singlethread_workqueue
Message-ID: <20160712124501.GW23520@phenom.ffwll.local>
Mail-Followup-To: Tejun Heo <tj@kernel.org>,
	Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
	Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
	Alex Deucher <alexander.deucher@amd.com>,
	Sinclair Yeh <syeh@vmware.com>,
	Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
	Jonathon Jongsma <jjongsma@redhat.com>,
	Jani Nikula <jani.nikula@intel.com>,
	John Keeping <john@metanate.com>,
	Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>,
	Noralf =?iso-8859-1?Q?Tr=F8nnes?= <noralf@tronnes.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20160702110209.GA3560@Karyakshetra>
 <20160702134417.GA17431@htj.duckdns.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160702134417.GA17431@htj.duckdns.org>
X-Operating-System: Linux phenom 4.6.0-rc5+ 
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 02, 2016 at 09:44:17AM -0400, Tejun Heo wrote:
> On Sat, Jul 02, 2016 at 04:32:09PM +0530, Bhaktipriya Shridhar wrote:
> > System workqueues have been able to handle high level of concurrency
> > for a long time now and there's no reason to use dedicated workqueues
> > just to gain concurrency. Since the workqueue in the QXL graphics device
> > driver is involved in freeing and processing the release ring
> > (workitem &qdev->gc_workqxl, maps to gc_work which calls
> > qxl_garbage_collect) and is not being used on a memory reclaim path,
> > dedicated gc_queue has been replaced with the use of system_wq.
> > 
> > Unlike a dedicated per-cpu workqueue created with create_workqueue(),
> > system_wq allows multiple work items to overlap executions even on
> > the same CPU; however, a per-cpu workqueue doesn't have any CPU
> > locality or global ordering guarantees unless the target CPU is
> > explicitly specified and thus the increase of local concurrency
> > shouldn't make any difference.
> > 
> > flush_work() has been called in qxl_device_fini() to ensure that there
> > are no pending tasks while disconnecting the driver.
> > 
> > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> 
> Acked-by: Tejun Heo <tj@kernel.org>

Applied to drm-misc, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch