From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751551AbcGLTvj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jul 2016 15:51:39 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:39560 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751282AbcGLTvh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jul 2016 15:51:37 -0400
Date: Tue, 12 Jul 2016 12:51:26 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: "Goel, Akash" <akash.goel@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>, linux-kernel@vger.kernel.org,
        viro@zeniv.linux.org.uk,
        Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
        Tom Zanussi <tzanussi@gmail.com>
Subject: Re: [PATCH v2] relay: Add global mode support for buffer-only
 channels
Message-Id: <20160712125126.f2b231596898a11cdef54308@linux-foundation.org>
In-Reply-To: <f150af9e-8f01-d703-3c8c-56aed88737b5@intel.com>
References: <b905c0b6-a295-882f-9714-cf259119e96c@intel.com>
	<1468221456-15537-1-git-send-email-akash.goel@intel.com>
	<20160711131709.4b2417f54b2eb9fd0fa19900@linux-foundation.org>
	<20160712092445.GN6157@nuc-i3427.alporthouse.com>
	<62e36dd1-85b3-2fa9-550e-c43780b5b33b@intel.com>
	<20160712130100.GT6157@nuc-i3427.alporthouse.com>
	<f150af9e-8f01-d703-3c8c-56aed88737b5@intel.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 12 Jul 2016 18:54:49 +0530 "Goel, Akash" <akash.goel@intel.com> wrote:

> 
> 
> On 7/12/2016 6:31 PM, Chris Wilson wrote:
> > On Tue, Jul 12, 2016 at 06:20:06PM +0530, Goel, Akash wrote:
> >> Thanks much, will update the documentation as well as the changelog
> >> as per the above.
> >>
> >> But an export of symbol relay_late_setup_files() is still needed, just
> >> like relay_open() is exported, in order to make it accessible to
> >> modules like i915 ?
> >
> > Yes, we need the companion function in i915.ko. That needs to be
> > explained in the patch notes to justify adding the EXPORT_SYMBOL.
> > Otherwise without that context, it looks unnecessary as Andrew objected
> > to.
> 
> Won't your suggested updates to Documentation & changelog suffice ?.
> relay_late_setup_files() is to be used in conjunction with
> relay_open(), hence need to be exported.
> 
> Do I also need to provide the corresponding i915 patch, which has a
> call to relay_late_setup_files() ?

No, as long as i915 people promise to use the export, a note in the
changelog is sufficient.