From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933347AbcGLNBv (ORCPT ); Tue, 12 Jul 2016 09:01:51 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:56765 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932485AbcGLNBt (ORCPT ); Tue, 12 Jul 2016 09:01:49 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Tue, 12 Jul 2016 14:01:00 +0100 From: Chris Wilson To: "Goel, Akash" Cc: Andrew Morton , linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, Eduard - Gabriel Munteanu , Tom Zanussi Subject: Re: [PATCH v2] relay: Add global mode support for buffer-only channels Message-ID: <20160712130100.GT6157@nuc-i3427.alporthouse.com> References: <1468221456-15537-1-git-send-email-akash.goel@intel.com> <20160711131709.4b2417f54b2eb9fd0fa19900@linux-foundation.org> <20160712092445.GN6157@nuc-i3427.alporthouse.com> <62e36dd1-85b3-2fa9-550e-c43780b5b33b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62e36dd1-85b3-2fa9-550e-c43780b5b33b@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2016 at 06:20:06PM +0530, Goel, Akash wrote: > Thanks much, will update the documentation as well as the changelog > as per the above. > > But an export of symbol relay_late_setup_files() is still needed, just > like relay_open() is exported, in order to make it accessible to > modules like i915 ? Yes, we need the companion function in i915.ko. That needs to be explained in the patch notes to justify adding the EXPORT_SYMBOL. Otherwise without that context, it looks unnecessary as Andrew objected to. -Chris -- Chris Wilson, Intel Open Source Technology Centre