From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1030228AbcGLO6J (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jul 2016 10:58:09 -0400
Received: from merlin.infradead.org ([205.233.59.134]:41374 "EHLO
	merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754335AbcGLO6H (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jul 2016 10:58:07 -0400
Date: Tue, 12 Jul 2016 16:57:57 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@ml01.01.org, Xiao Guangrong <guangrong.xiao@linux.intel.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Adrian Hunter <adrian.hunter@intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>, hch@lst.de,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, linux-fsdevel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@suse.de>,
        Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH v2 16/17] x86/insn: remove pcommit
Message-ID: <20160712145757.GV30909@twins.programming.kicks-ass.net>
References: <146812106839.32932.2870621200867047059.stgit@dwillia2-desk3.amr.corp.intel.com>
 <146812115425.32932.3314855641604340233.stgit@dwillia2-desk3.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <146812115425.32932.3314855641604340233.stgit@dwillia2-desk3.amr.corp.intel.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 09, 2016 at 08:25:54PM -0700, Dan Williams wrote:
> The pcommit instruction is being deprecated in favor of either ADR
> (asynchronous DRAM refresh: flush-on-power-fail) at the platform level, or
> posted-write-queue flush addresses as defined by the ACPI 6.x NFIT (NVDIMM
> Firmware Interface Table).

>  arch/x86/include/asm/cpufeatures.h                 |    1 
>  arch/x86/include/asm/special_insns.h               |   46 --------------------
>  arch/x86/lib/x86-opcode-map.txt                    |    2 -
>  tools/objtool/arch/x86/insn/x86-opcode-map.txt     |    2 -
>  tools/perf/arch/x86/tests/insn-x86-dat-32.c        |    2 -
>  tools/perf/arch/x86/tests/insn-x86-dat-64.c        |    2 -
>  tools/perf/arch/x86/tests/insn-x86-dat-src.c       |    4 --

Just deprecated, or is it completely eradicated, removed from history,
will never ever happen and we'll reissue the opcode for something else?

Because if its only deprecated then removing it from the instruction
decoders seems wrong, old binaries might still contain the opcode.