From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933613AbcGLPX0 (ORCPT ); Tue, 12 Jul 2016 11:23:26 -0400 Received: from foss.arm.com ([217.140.101.70]:60111 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933252AbcGLPXY (ORCPT ); Tue, 12 Jul 2016 11:23:24 -0400 Date: Tue, 12 Jul 2016 16:23:19 +0100 From: Catalin Marinas To: Sudeep Holla Cc: ACPI List , "Rafael J . Wysocki" , Mark Rutland , Lorenzo Pieralisi , Prashanth Prakash , Al Stone , Vikas Sajjan , Daniel Lezcano , LKML , Ashwin Chaugule , ALKML , Sunil Subject: Re: [PATCH v9 3/7] arm64: cpuidle: drop __init section marker to arm_cpuidle_init Message-ID: <20160712152319.GG22183@e104818-lin.cambridge.arm.com> References: <1467997678-7107-1-git-send-email-sudeep.holla@arm.com> <1467997678-7107-4-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467997678-7107-4-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 06:07:54PM +0100, Sudeep Holla wrote: > Commit ea389daa7fd9 ("arm64: cpuidle: add __init section marker to > arm_cpuidle_init") added the __init annotation to arm_cpuidle_init > as it was not needed after booting which was correct at that time. > > However with the introduction of ACPI LPI support, this will be used > from cpuhotplug path in ACPI processor driver. > > This patch drops the __init annotation from arm_cpuidle_init to avoid > the following warning: > > WARNING: vmlinux.o(.text+0x113c8): Section mismatch in reference from the > function acpi_processor_ffh_lpi_probe() to the function > .init.text:arm_cpuidle_init() > The function acpi_processor_ffh_lpi_probe() references > the function __init arm_cpuidle_init(). > This is often because acpi_processor_ffh_lpi_probe lacks a __init > annotation or the annotation of arm_cpuidle_init is wrong. > > Cc: Mark Rutland > Acked-by: Lorenzo Pieralisi > Signed-off-by: Sudeep Holla Acked-by: Catalin Marinas