From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751822AbcGLTsU (ORCPT ); Tue, 12 Jul 2016 15:48:20 -0400 Received: from smtprelay0218.hostedemail.com ([216.40.44.218]:52422 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751193AbcGLTsS (ORCPT ); Tue, 12 Jul 2016 15:48:18 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:421:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3871:3872:3873:3874:4321:5007:6119:6261:7875:7901:7903:9040:10004:10400:10848:10967:11026:11232:11658:11914:12517:12519:12740:13069:13311:13357:13439:14181:14659:14721:21080:21324:30012:30041:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: feet54_81b698c96ab1d X-Filterd-Recvd-Size: 2856 Date: Tue, 12 Jul 2016 15:48:10 -0400 From: Steven Rostedt To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH 10/10] perf script python: Fix string vs byte array resolving Message-ID: <20160712154810.23f8afd2@gandalf.local.home> In-Reply-To: <20160712192716.GH3387@kernel.org> References: <1468148882-10362-1-git-send-email-jolsa@kernel.org> <1468148882-10362-11-git-send-email-jolsa@kernel.org> <20160711115452.02ba1d6c@gandalf.local.home> <20160712081156.GB3392@krava> <20160712083728.2c468986@gandalf.local.home> <20160712125245.GA20585@krava> <20160712090001.0e8cdb6d@gandalf.local.home> <20160712133552.GA30438@krava> <20160712094836.0069bc20@gandalf.local.home> <20160712192716.GH3387@kernel.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jul 2016 16:27:16 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 12, 2016 at 09:48:36AM -0400, Steven Rostedt escreveu: > > On Tue, 12 Jul 2016 15:35:52 +0200 > > Jiri Olsa wrote: > > > > > On Tue, Jul 12, 2016 at 09:00:01AM -0400, Steven Rostedt wrote: > > > > On Tue, 12 Jul 2016 14:52:45 +0200 > > > > Jiri Olsa wrote: > > > > > > > > > > > > > hum, so string is not passed to trace buffer with 0 at the end? > > > > > > > > strlen() returns only the length of the string (minus the \0 at the > > > > end). > > > > > > yea, is_printable_array is called here on tracepoint > > > data that's why I asked.. is 0 part of the string data > > > when stored within tracepoint? > > > > Good question. It may or may not (haven't looked at the code), but we > > probably want to make sure that the function is robust enough for > > either case. > > Ok, applied and tested up to patch 9, waiting for this discussion to > come to an end to consider 10. > > - Arnaldo > > > > > Or you can do: > > > > > > > > if (p[len - 1] == 0) > > > > len--; > > > > > > > > for (i = 0; i < len; i++) > > > > if (!isprint(p[i]) && !isspace(p[i])) > > > > return 0; > > > > return 1; > > > > > > yep, seems good.. thanks > > > > > > > OK, great! I think Jiri is going to implement the above. -- Steve