From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbcGLXLS (ORCPT ); Tue, 12 Jul 2016 19:11:18 -0400 Received: from smtprelay0183.hostedemail.com ([216.40.44.183]:40572 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751227AbcGLXLR (ORCPT ); Tue, 12 Jul 2016 19:11:17 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:6119:6261:7514:7576:7875:9025:10004:10400:10848:10903:10967:11026:11232:11257:11658:11914:12043:12438:12517:12519:12555:12740:13069:13311:13357:13439:14106:14181:14659:14721:21080:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: hook67_a2c717b03035 X-Filterd-Recvd-Size: 2930 Date: Tue, 12 Jul 2016 19:11:08 -0400 From: Steven Rostedt To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , David Ahern , Jiri Olsa , Namhyung Kim , Wang Nan Subject: Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Message-ID: <20160712191108.63d23fae@gandalf.local.home> In-Reply-To: <1468363241-14555-30-git-send-email-acme@kernel.org> References: <1468363241-14555-1-git-send-email-acme@kernel.org> <1468363241-14555-30-git-send-email-acme@kernel.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jul 2016 19:40:04 -0300 Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > To make it portable to non-glibc systems, that follow the XSI variant > instead of the GNU specific one that gets in place when _GNU_SOURCE is > defined. > > Cc: Adrian Hunter > Cc: David Ahern > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Steven Rostedt > Cc: Wang Nan > Link: http://lkml.kernel.org/n/tip-c1gn8x978qfop65m510wy43o@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/lib/traceevent/event-parse.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > index a8b6357d1ffe..3a7bd175f73c 100644 > --- a/tools/lib/traceevent/event-parse.c > +++ b/tools/lib/traceevent/event-parse.c > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include > > #include > #include "event-parse.h" > @@ -6131,12 +6132,7 @@ int pevent_strerror(struct pevent *pevent __maybe_unused, > const char *msg; > > if (errnum >= 0) { > - msg = strerror_r(errnum, buf, buflen); > - if (msg != buf) { > - size_t len = strlen(msg); > - memcpy(buf, msg, min(buflen - 1, len)); > - *(buf + min(buflen - 1, len)) = '\0'; > - } > + str_error_r(errnum, buf, buflen); > return 0; What library is used with this? When I port this over to trace-cmd (which is still needed as I develop this there), it fails to build. "undefined reference to str_error_r" -- Steve > } >