From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbcGLXZh (ORCPT ); Tue, 12 Jul 2016 19:25:37 -0400 Received: from smtprelay0185.hostedemail.com ([216.40.44.185]:54366 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751228AbcGLXZ2 (ORCPT ); Tue, 12 Jul 2016 19:25:28 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:5007:6119:6261:7875:8957:9108:10004:10400:10848:10903:10967:11026:11232:11658:11914:12517:12519:12740:13069:13161:13229:13311:13357:13439:14181:14659:14721:21080:21433:30054:30064:30079:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: heart14_85f2c9ea6732a X-Filterd-Recvd-Size: 2352 Date: Tue, 12 Jul 2016 19:25:19 -0400 From: Steven Rostedt To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , David Ahern , Jiri Olsa , Namhyung Kim , Wang Nan Subject: Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Message-ID: <20160712192519.601b1fae@gandalf.local.home> In-Reply-To: <20160712231424.GA26691@kernel.org> References: <1468363241-14555-1-git-send-email-acme@kernel.org> <1468363241-14555-30-git-send-email-acme@kernel.org> <20160712191108.63d23fae@gandalf.local.home> <20160712231424.GA26691@kernel.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jul 2016 20:14:24 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 12, 2016 at 07:11:08PM -0400, Steven Rostedt escreveu: > > On Tue, 12 Jul 2016 19:40:04 -0300 Arnaldo Carvalho de Melo wrote: > > > To make it portable to non-glibc systems, that follow the XSI variant > > > instead of the GNU specific one that gets in place when _GNU_SOURCE is > > > defined. > > > > #include "event-parse.h" > > > @@ -6131,12 +6132,7 @@ int pevent_strerror(struct pevent *pevent __maybe_unused, > > > + str_error_r(errnum, buf, buflen); > > > return 0; > > > > What library is used with this? When I port this over to trace-cmd > > (which is still needed as I develop this there), it fails to build. > > "undefined reference to str_error_r" > > tools/lib/str_error_r.c > > Forgot about the out of tree copy :-\ > Yeah, we really need to make this into a real library. I haven't had the time to do that. Hopefully in August I can talk with some people at LinuxCon to see the best way to go about doing that. Anyway, I may just take that file and port it to trace-cmd. -- Steve