From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752193AbcGMM7C (ORCPT ); Wed, 13 Jul 2016 08:59:02 -0400 Received: from down.free-electrons.com ([37.187.137.238]:45254 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751138AbcGMM6z (ORCPT ); Wed, 13 Jul 2016 08:58:55 -0400 Date: Wed, 13 Jul 2016 14:58:41 +0200 From: Boris Brezillon To: weiyj_lk@163.com Cc: David Airlie , Wei Yongjun , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding Subject: Re: [PATCH -next] drm: atmel-hlcdc: fix non static symbol warning Message-ID: <20160713145841.32b12eff@bbrezillon> In-Reply-To: <1468413783-2163-1-git-send-email-weiyj_lk@163.com> References: <1468413783-2163-1-git-send-email-weiyj_lk@163.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jul 2016 12:43:03 +0000 weiyj_lk@163.com wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning: > symbol 'atmel_hlcdc_crtc_reset' was not declared. Should it be static? Sorry but Thierry already proposed the same fix a few days ago. > > Signed-off-by: Wei Yongjun > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index a978381..9b17a66 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -387,7 +387,7 @@ void atmel_hlcdc_crtc_irq(struct drm_crtc *c) > atmel_hlcdc_crtc_finish_page_flip(drm_crtc_to_atmel_hlcdc_crtc(c)); > } > > -void atmel_hlcdc_crtc_reset(struct drm_crtc *crtc) > +static void atmel_hlcdc_crtc_reset(struct drm_crtc *crtc) > { > struct atmel_hlcdc_crtc_state *state; > > > > >