From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751374AbcGMUta (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jul 2016 16:49:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44888 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750883AbcGMUtU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jul 2016 16:49:20 -0400
Date: Wed, 13 Jul 2016 15:49:14 -0500
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, linux-kernel@vger.kernel.org,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Alexander Yarygin <yarygin@linux.vnet.ibm.com>,
        Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Chris Phlipot <cphlipot0@gmail.com>,
        Christoffer Dall <christoffer.dall@linaro.org>,
        David Ahern <dsahern@gmail.com>, Davidlohr Bueso <dbueso@suse.de>,
        David Tolnay <dtolnay@gmail.com>, Eric Auger <eric.auger@linaro.org>,
        Hemant Kumar <hemant@linux.vnet.ibm.com>,
        Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
        Jiri Olsa <jolsa@kernel.org>, Marc Zyngier <marc.zyngier@arm.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        "Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Peter Zijlstra <peterz@infradead.org>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Vineet Gupta <vgupta@synopsys.com>, Wang Nan <wangnan0@huawei.com>,
        Yunlong Song <yunlong.song@huawei.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL 00/66] perf/core improvements and fixes
Message-ID: <20160713204914.zs77db76wuvharn6@treble>
References: <1468363241-14555-1-git-send-email-acme@kernel.org>
 <20160713065906.GA13006@gmail.com>
 <20160713073527.GA28210@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160713073527.GA28210@gmail.com>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 13 Jul 2016 20:49:19 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2016 at 09:35:27AM +0200, Ingo Molnar wrote:
> 
> Hm, the objtool build broke:
> 
>   GEN      arch/x86/insn/inat-tables.c
>   CC       arch/x86/decode.o
> In file included from /home/mingo/tip/tools/include/linux/hashtable.h:12:0,
>                  from arch/x86/../../elf.h:24,
>                  from arch/x86/decode.c:26:
> /home/mingo/tip/tools/include/linux/bitops.h:12:0: error: "BITS_PER_LONG" 
> redefined [-Werror]
>  #define BITS_PER_LONG __WORDSIZE
>  ^
> In file included from /usr/include/x86_64-linux-gnu/asm/bitsperlong.h:10:0,
>                  from /usr/include/asm-generic/int-ll64.h:11,
>                  from /usr/include/asm-generic/types.h:6,
>                  from /usr/include/x86_64-linux-gnu/asm/types.h:4,
>                  from /home/mingo/tip/tools/include/linux/types.h:9,
>                  from /home/mingo/tip/tools/include/linux/list.h:4,
>                  from arch/x86/../../elf.h:23,
>                  from arch/x86/decode.c:26:
> /home/mingo/tip/tools/include/asm-generic/bitsperlong.h:10:0: note: this is the 
> location of the previous definition
>  #define BITS_PER_LONG 32
>  ^

Hi Ingo,

There's still another issue.  Notice in the last line there that
BITS_PER_LONG is getting incorrectly set to 32, at least for objtool.

That '#define BITS_PER_LONG 32' comes from the following code in
tools/include/asm-generic/bitsperlong.h:

  #ifdef CONFIG_64BIT
  #define BITS_PER_LONG 64
  #else
  #define BITS_PER_LONG 32
  #endif /* CONFIG_64BIT */

Because objtool doesn't have CONFIG_64BIT defined, it falls through to
the '#else' condition.  I think tools code shouldn't be relying on
kernel config options.

-- 
Josh