From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751457AbcGMWod (ORCPT ); Wed, 13 Jul 2016 18:44:33 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:35152 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbcGMWoZ (ORCPT ); Wed, 13 Jul 2016 18:44:25 -0400 Date: Thu, 14 Jul 2016 01:44:20 +0300 From: Alexey Dobriyan To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] uapi: move forward declarations of internal structures Message-ID: <20160713224420.GA15618@p183.telecom.by> References: <20160713215808.GA22486@p183.telecom.by> <20160713151557.a87f48b707f628c7cc5c6505@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160713151557.a87f48b707f628c7cc5c6505@linux-foundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2016 at 03:15:57PM -0700, Andrew Morton wrote: > On Thu, 14 Jul 2016 00:58:08 +0300 Alexey Dobriyan wrote: > > > Move "struct completion;". > > Move "struct task_struct;". > > That tells us no more than does the diff. > > What's the reason for this change? Any perceptible benefit? You're right. Changelog should be Don't user forward declarations of internal kernel structures in headers exported to userspace.