From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932114AbcGOFQ2 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Jul 2016 01:16:28 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:39556 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750870AbcGOFQZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Jul 2016 01:16:25 -0400
Date: Thu, 14 Jul 2016 22:16:24 -0700 (PDT)
Message-Id: <20160714.221624.1127895350526666434.davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, arnd@arndb.de, rdunlap@infradead.org,
        linux-kernel@vger.kernel.org, idosch@mellanox.com, yotamg@mellanox.com,
        eladr@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com,
        ivecera@redhat.com, rostedt@goodmis.org, mingo@redhat.com,
        jolsa@kernel.org
Subject: Re: [patch net-next 2/2] devlink: fix trace format string
From: David Miller <davem@davemloft.net>
In-Reply-To: <1468489049-6326-2-git-send-email-jiri@resnulli.us>
References: <1468489049-6326-1-git-send-email-jiri@resnulli.us>
	<1468489049-6326-2-git-send-email-jiri@resnulli.us>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 Jul 2016 22:16:25 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 14 Jul 2016 11:37:29 +0200

> From: Arnd Bergmann <arnd@arndb.de>
> 
> Including devlink.h on ARM and probably other 32-bit architectures results in
> a harmless warning:
> 
> In file included from ../include/trace/define_trace.h:95:0,
>                  from ../include/trace/events/devlink.h:51,
>                  from ../net/core/devlink.c:30:
> include/trace/events/devlink.h: In function 'trace_raw_output_devlink_hwmsg':
> include/trace/events/devlink.h:42:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 10 has type 'size_t {aka unsigned int}' [-Werror=format=]
> 
> The correct format string for 'size_t' is %zu, not %lu, this works on all
> architectures.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: e5224f0fe2ac ("devlink: add hardware messages tracing facility")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Applied.