From: Masami Hiramatsu <mhiramat@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: ananth@linux.vnet.ibm.com, anil.s.keshavamurthy@intel.com,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h>
Date: Thu, 14 Jul 2016 00:13:00 +0900 [thread overview]
Message-ID: <20160714001300.2e70fe9b3cfb98d5e92e8620@kernel.org> (raw)
In-Reply-To: <1468285056-7380-1-git-send-email-hch@lst.de>
On Tue, 12 Jul 2016 09:57:36 +0900
Christoph Hellwig <hch@lst.de> wrote:
> asm-generic headers are generic implementations for architecture specific
> code and should not be included by common code. Thus use the asm/ version
> of sections.h to get at the linker sections.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me. Thanks Christoph!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index d10ab6b..d630954 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -49,7 +49,7 @@
> #include <linux/cpu.h>
> #include <linux/jump_label.h>
>
> -#include <asm-generic/sections.h>
> +#include <asm/sections.h>
> #include <asm/cacheflush.h>
> #include <asm/errno.h>
> #include <asm/uaccess.h>
> --
> 2.1.4
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2016-07-13 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 0:57 Christoph Hellwig
2016-07-13 15:13 ` Masami Hiramatsu [this message]
2016-09-11 13:58 Christoph Hellwig
2016-09-12 10:46 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714001300.2e70fe9b3cfb98d5e92e8620@kernel.org \
--to=mhiramat@kernel.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome