From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751191AbcGNIvs (ORCPT ); Thu, 14 Jul 2016 04:51:48 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35238 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750930AbcGNIvm (ORCPT ); Thu, 14 Jul 2016 04:51:42 -0400 Date: Thu, 14 Jul 2016 10:51:38 +0200 From: Jiri Pirko To: Arnd Bergmann Cc: Jiri Pirko , netdev@vger.kernel.org, Steven Rostedt , Ingo Molnar , "David S . Miller" , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n Message-ID: <20160714085138.GD2228@nanopsycho.orion> References: <20160713210338.1647521-1-arnd@arndb.de> <20160714062111.GA2228@nanopsycho.orion> <4442123.LuHpPd1R94@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4442123.LuHpPd1R94@wuerfel> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thu, Jul 14, 2016 at 10:12:43AM CEST, arnd@arndb.de wrote: >On Thursday, July 14, 2016 8:21:11 AM CEST Jiri Pirko wrote: >> >diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h >> >index 333c32ac9bfa..26f92d3c7e9c 100644 >> >--- a/include/trace/events/devlink.h >> >+++ b/include/trace/events/devlink.h >> >@@ -22,7 +22,11 @@ TRACE_EVENT(devlink_hwmsg, >> > TP_STRUCT__entry( >> > __string(bus_name, devlink->dev->bus->name) >> > __string(dev_name, dev_name(devlink->dev)) >> >+#ifdef CONFIG_MODULES >> > __string(owner_name, devlink->dev->driver->owner->name) >> >> I think would be better to use driver->name. I looks like it is always >> present. I will do some tests and send a patch. >> > >Yes, good idea. I will take your second path, rebase and send along. Thanks. > > Arnd >