From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751931AbcGNQJz (ORCPT ); Thu, 14 Jul 2016 12:09:55 -0400 Received: from smtprelay0127.hostedemail.com ([216.40.44.127]:36388 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751150AbcGNQJv (ORCPT ); Thu, 14 Jul 2016 12:09:51 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3872:3873:3874:4321:5007:6261:7875:9010:10004:10400:10848:10967:11026:11232:11473:11658:11914:12198:12296:12438:12517:12519:12555:12740:13069:13255:13311:13357:13439:14096:14097:14181:14659:14721:21080:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: snail76_515a8e4d45202 X-Filterd-Recvd-Size: 2030 Date: Thu, 14 Jul 2016 12:09:17 -0400 From: Steven Rostedt To: Sebastian Andrzej Siewior Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [RT PATCH 2/2] timers: wakeup all timer waiters without holding the base lock Message-ID: <20160714120917.038b215b@gandalf.local.home> In-Reply-To: <1468512304-15310-2-git-send-email-bigeasy@linutronix.de> References: <1468512304-15310-1-git-send-email-bigeasy@linutronix.de> <1468512304-15310-2-git-send-email-bigeasy@linutronix.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jul 2016 18:05:04 +0200 Sebastian Andrzej Siewior wrote: > There should be no need to hold the base lock during the wakeup. There > should be no boosting involved, the wakeup list has its own lock so it > should be safe to do this without the lock. > > Cc: stable-rt@vger.kernel.org Nothing against this patch, but as you marked it for stable, can you add to the change log what issue you had that caused you to make this change? -- Steve > Signed-off-by: Sebastian Andrzej Siewior > --- > kernel/time/timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/time/timer.c b/kernel/time/timer.c > index b3c3d3a6216f..716ef84a5d87 100644 > --- a/kernel/time/timer.c > +++ b/kernel/time/timer.c > @@ -1313,8 +1313,8 @@ static inline void __run_timers(struct tvec_base *base) > } > } > } > - wakeup_timer_waiters(base); > spin_unlock_irq(&base->lock); > + wakeup_timer_waiters(base); > } > > #ifdef CONFIG_NO_HZ_COMMON