From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751633AbcGNPsd (ORCPT ); Thu, 14 Jul 2016 11:48:33 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45372 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbcGNPsb (ORCPT ); Thu, 14 Jul 2016 11:48:31 -0400 Date: Thu, 14 Jul 2016 16:48:21 +0100 From: Mark Brown To: Steve Twiss Cc: DEVICETREE , LINUXKERNEL , Liam Girdwood , Mark Rutland , Rob Herring , Support Opensource Message-ID: <20160714154821.GA30372@sirena.org.uk> References: <20160713154433.496843FAD9@swsrvapps-01.diasemi.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline In-Reply-To: <20160713154433.496843FAD9@swsrvapps-01.diasemi.com> X-Cookie: It's later than you think. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V1] regulator: da9210: addition of device tree support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 13, 2016 at 04:41:19PM +0100, Steve Twiss wrote: > Two files are modified, the driver source file and the binding document. > Updates for the regulator source file include an .of_match_table entry, node > match checking in the probe() function for a compatible da9210 string, and > a new "BUCK" regulator entry. The binding documentation changes have been > made to reflect these updates. If the device only has one regulator and no other functionality I'd expect the properties to just be in the top level node for the device - no need to go fiddling around with a subnode to hold another subnode to hold all the properties. --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXh7REAAoJECTWi3JdVIfQCv4IAILgOPlda2npBqRig7IArbsm dY4naqX70nOBD7+ceKBc+nGLl5mDP2Hafibq5gkKnW9uA5fhTXrPpc0YQJmxrG+7 0Cua3cN9Rn3YxhKuAPVCFrOsDFwPYWuFzpkQk8Mk2rxG6jkEc6Xq1dSNI3cumyCP F9cE0d4eh7hGbwWMv4pncbe3iJkCdXH2IccWdf2WvEL5jZlL7stS9/HU401P0dgY zd8NDEC20Tt0FBalFVBL0NzQrA1jRUgjDhhw/QLNCcUuDrgPzTyPqnVBLWgJbakc RH+k4LLITQAgNaerY6nqtJVIwEPBEwMj9VAc9iEdy2LhWtBLZvrnt3DgIo8o1aI= =VL6c -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J--