From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751477AbcGNQIO (ORCPT ); Thu, 14 Jul 2016 12:08:14 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:37422 "EHLO mail-it0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbcGNQIL (ORCPT ); Thu, 14 Jul 2016 12:08:11 -0400 Date: Thu, 14 Jul 2016 09:08:03 -0700 From: Benjamin Poirier To: Matt Wilson Cc: Netanel Belgazal , David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zorik@annapurnalabs.com, saeed@annapurnalabs.com, alex@annapurnalabs.com, aliguori@amazon.com, ben@decadent.org.uk, romieu@fr.zoreil.com, rami.rosen@intel.com, antoine.tenart@free-electrons.com, "John W. Linville" Subject: Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Message-ID: <20160714160803.egrmos7soc6qvrry@f1.synalogic.ca> References: <1468478774-19942-1-git-send-email-netanel@annapurnalabs.com> <20160714152215.GA24590@u54ee753d2d1854bda401.ant.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160714152215.GA24590@u54ee753d2d1854bda401.ant.amazon.com> User-Agent: Mutt/1.6.1-neo (2016-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/07/14 08:22, Matt Wilson wrote: [...] > > Dave and Benjamin, > > Do you want to see the interrupt moderation extensions to ethtool and > the sysfs nodes removed before this lands in net-next? Or should > Netanel remove the sysfs bits until we can extend the ethtool > interfaces to cover the parameters that ena uses? I couldn't say what's acceptable or not. A few other drivers (qlcnic, sfc, ...) already have sysfs tunables. Maybe John, as the new ethtool maintainer, can weight in too about the changes required to ethtool.