From: Matt Wilson <msw@amzn.com>
To: Benjamin Poirier <benjamin.poirier@gmail.com>
Cc: Netanel Belgazal <netanel@annapurnalabs.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
zorik@annapurnalabs.com, saeed@annapurnalabs.com,
alex@annapurnalabs.com, aliguori@amazon.com, ben@decadent.org.uk,
romieu@fr.zoreil.com, rami.rosen@intel.com,
antoine.tenart@free-electrons.com,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date: Thu, 14 Jul 2016 09:15:11 -0700 [thread overview]
Message-ID: <20160714161511.GA30697@u54ee753d2d1854bda401.ant.amazon.com> (raw)
In-Reply-To: <20160714160803.egrmos7soc6qvrry@f1.synalogic.ca>
On Thu, Jul 14, 2016 at 09:08:03AM -0700, Benjamin Poirier wrote:
> On 2016/07/14 08:22, Matt Wilson wrote:
> [...]
> >
> > Dave and Benjamin,
> >
> > Do you want to see the interrupt moderation extensions to ethtool and
> > the sysfs nodes removed before this lands in net-next? Or should
> > Netanel remove the sysfs bits until we can extend the ethtool
> > interfaces to cover the parameters that ena uses?
>
> I couldn't say what's acceptable or not. A few other drivers (qlcnic,
> sfc, ...) already have sysfs tunables. Maybe John, as the new ethtool
> maintainer, can weight in too about the changes required to ethtool.
We definitely want ethtool to handle all the settings, it's just a
question of when. We also want to address and resolve all the great
feedback so far, and since you originally raised the point about
extending ethtool I wanted to see if you have any major objection.
--msw
next prev parent reply other threads:[~2016-07-14 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 6:46 Netanel Belgazal
2016-07-14 15:22 ` Matt Wilson
2016-07-14 16:08 ` Benjamin Poirier
2016-07-14 16:15 ` Matt Wilson [this message]
2016-07-15 18:29 ` David Miller
2016-07-15 5:00 ` Leon Romanovsky
2016-07-15 15:17 ` Benjamin Poirier
2016-07-15 15:47 ` Leon Romanovsky
2016-07-19 11:09 ` Netanel Belgazal
2016-07-19 17:26 ` Leon Romanovsky
2016-07-19 17:49 ` Joe Perches
2016-07-25 5:06 ` Leon Romanovsky
2016-07-19 18:39 ` Netanel Belgazal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714161511.GA30697@u54ee753d2d1854bda401.ant.amazon.com \
--to=msw@amzn.com \
--cc=alex@annapurnalabs.com \
--cc=aliguori@amazon.com \
--cc=antoine.tenart@free-electrons.com \
--cc=ben@decadent.org.uk \
--cc=benjamin.poirier@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netanel@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=rami.rosen@intel.com \
--cc=romieu@fr.zoreil.com \
--cc=saeed@annapurnalabs.com \
--cc=zorik@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®