From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751684AbcGNQVY (ORCPT ); Thu, 14 Jul 2016 12:21:24 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45452 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbcGNQVV (ORCPT ); Thu, 14 Jul 2016 12:21:21 -0400 Date: Thu, 14 Jul 2016 17:20:59 +0100 From: Mark Brown To: Cyrille Pitchen Cc: nicolas.ferre@atmel.com, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org Message-ID: <20160714162059.GB30372@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qcHopEYAB45HaUaB" Content-Disposition: inline In-Reply-To: X-Cookie: It's later than you think. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 2/2] ASoC: atmel-i2s: add driver for the new Atmel I2S controller X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qcHopEYAB45HaUaB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 13, 2016 at 12:25:39PM +0200, Cyrille Pitchen wrote: A few small things but otherwise this looks good: > + switch (params_channels(params)) { > + case 1: > + mr |= is_playback ? ATMEL_I2SC_MR_TXMONO : ATMEL_I2SC_MR_RXMONO; Please write normal if statements, it makes things easier to read. > + break; > + case 2: > + break; > + default: > + dev_err(dev->dev, "unsupported number of audio channels\n"); > + break; > + } Why don't we return an error if we don't support the requested number of channels? > + dev->gclk = devm_clk_get(&pdev->dev, "gclk"); > + if (IS_ERR(dev->aclk) && IS_ERR(dev->gclk)) { > + /* Master Mode not supported */ > + dev->aclk = NULL; > + dev->gclk = NULL; This won't handle probe deferral properly, it'll just ignore the clocks if we get -EPROBE_DEFER. The driver should special case that at least. --qcHopEYAB45HaUaB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXh7vqAAoJECTWi3JdVIfQPhsH/jdMog1xqf1sed8sRo+uUxR+ 9o8FtNAtJOFrWoUa/VJghiegqbxwvQ/mBrqY3I5fd1B/c4Vj43k7sEkXccusgy9r 19fKm9EmHshJdgdtKENNL0foBetRHUk+ujZ7cF7Uo0qkuV1C2GXfZD1Y5wT6TfZ3 0JonAXVXp8ezlMZ7zugm3cRHQLCA0SykfrUSHG4J40yC641CPh1tbbnF/+5pVK4/ RdmFqEP1nJKvsx7EtZsaPm3LYt8FkFDtcwRIJiXG4jeNyvMqky0NWx9a5Jj9Gs8p Qc9Xr+oHK/A6GuSAnch4bNuZabTi13W4hqj2DL+4dTUGfXa1kNUijKqp9M6TwQ8= =epbI -----END PGP SIGNATURE----- --qcHopEYAB45HaUaB--