From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752403AbcGODIR (ORCPT ); Thu, 14 Jul 2016 23:08:17 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:50538 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbcGODIP (ORCPT ); Thu, 14 Jul 2016 23:08:15 -0400 Date: Thu, 14 Jul 2016 21:08:10 -0600 From: Jason Gunthorpe To: Andrey Pronin Cc: Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org Subject: Re: [PATCH 1/2] tpm: define constants for tpm2 properties Message-ID: <20160715030810.GB9347@obsidianresearch.com> References: <1468544838-9990-1-git-send-email-apronin@chromium.org> <1468544838-9990-2-git-send-email-apronin@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468544838-9990-2-git-send-email-apronin@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 06:07:17PM -0700, Andrey Pronin wrote: > Change-Id: I47cb1793736781fbea93e5bf80b783e0ac9e8628 These commit messages are no good, generally for all your patches. Drop the internal change-id and provide a suitable description. Do not add dead code to the kernel, so this patch should be in a series that actually uses the new constants. Jason