From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linaro-kernel@lists.linaro.org,
Build bot for Mark Brown <broonie@kernel.org>,
kernel-build-reports@lists.linaro.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: v4.4.12-rt20 build: 0 failures 5 warnings (v4.4.12-rt20)
Date: Fri, 15 Jul 2016 14:05:27 +0200 [thread overview]
Message-ID: <20160715120527.GB11606@linutronix.de> (raw)
In-Reply-To: <4402302.GjsxlnvCX4@wuerfel>
* Arnd Bergmann | 2016-07-15 09:07:20 [+0200]:
>Cc linux-rt-users@vger.kernel.org, let's have a look at the individual warnings:
thanks.
>
>> Warnings Summary: 5
>> 9 ../kernel/sched/core.c:3473:12: warning: 'preemptible_lazy' defined but not used [-Wunused-function]
>
>This was introduced by the rt patchset, I'd suggest adding a fix to the next
>v4.4-rt release. This is almost certainly harmless.
has been adressed in 4.6.4-rt8 and is harmless.
>> 2 ../include/linux/spinlock.h:246:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
>I'm missing context here, so I don't know what caused it, but the warning is
>not present in v4.4.12 (without -rt), so it's worth looking into.
the full log:
|In file included from include/linux/seqlock.h:35:0,
| from include/linux/time.h:5,
| from include/uapi/linux/timex.h:56,
| from include/linux/timex.h:56,
| from include/linux/sched.h:19,
| from arch/arm64/include/asm/compat.h:25,
| from arch/arm64/include/asm/stat.h:23,
| from include/linux/stat.h:5,
| from include/linux/module.h:10,
| from drivers/tty/serial/amba-pl011.c:37:
|drivers/tty/serial/amba-pl011.c: In function ‘pl011_console_write’:
|include/linux/spinlock.h:246:3: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized]
| _raw_spin_unlock_irqrestore(lock, flags); \
| ^
|drivers/tty/serial/amba-pl011.c:2065:16: note: ‘flags’ was declared here
| unsigned long flags;
| ^
and relevant part of the source:
|pl011_console_write(struct console *co, const char *s, unsigned int count)
|{
…
| unsigned long flags;
| int locked = 1;
|
…
| if (uap->port.sysrq)
| locked = 0;
| else if (oops_in_progress)
| locked = spin_trylock_irqsave(&uap->port.lock, flags);
| else
| spin_lock_irqsave(&uap->port.lock, flags);
…
| if (locked)
| spin_unlock_irqrestore(&uap->port.lock, flags);
…
|}
looks like a false positive to me.
> Arnd
Sebastian
next prev parent reply other threads:[~2016-07-15 12:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1bNugf-00064t-KA@optimist>
2016-07-15 7:07 ` Arnd Bergmann
2016-07-15 12:05 ` Sebastian Andrzej Siewior [this message]
2016-07-15 12:29 ` Arnd Bergmann
2016-07-15 13:23 ` Sebastian Andrzej Siewior
2016-07-15 19:48 ` Arnd Bergmann
2016-07-29 15:23 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715120527.GB11606@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®