From: Mark Brown <broonie@kernel.org>
To: njaigane@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, linux@qca.qualcomm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
twp@codeaurora.org, andy.gross@linaro.org,
david.brown@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux@armlinux.org.uk,
mturquette@baylibre.com, sboyd@codeaurora.org,
linus.walleij@linaro.org, plai@codeaurora.org,
bgoswami@codeaurora.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, bjorn.andersson@linaro.org,
varada@codeaurora.org, pradeepb@codeaurora.org,
snlakshm@codeaurora.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, alsa-devel@alsa-project.org,
bselvara@codeaurora.org
Subject: Re: [PATCH 4/4] qcom: ipq4019: Add ASoC driver modules
Date: Fri, 15 Jul 2016 13:52:26 +0100 [thread overview]
Message-ID: <20160715125226.GJ30372@sirena.org.uk> (raw)
In-Reply-To: <1468566426-19598-5-git-send-email-njaigane@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]
On Fri, Jul 15, 2016 at 12:37:06PM +0530, njaigane@codeaurora.org wrote:
> sound/soc/qcom/Kconfig | 47 ++
> sound/soc/qcom/Makefile | 1 +
> sound/soc/qcom/ipq4019/Makefile | 16 +
> sound/soc/qcom/ipq4019/ipq4019-adss.c | 407 ++++++++++++++
> sound/soc/qcom/ipq4019/ipq4019-adss.h | 432 +++++++++++++++
> sound/soc/qcom/ipq4019/ipq4019-codec.c | 475 +++++++++++++++++
> sound/soc/qcom/ipq4019/ipq4019-codec.h | 91 ++++
> sound/soc/qcom/ipq4019/ipq4019-cpu-dai.c | 687 ++++++++++++++++++++++++
> sound/soc/qcom/ipq4019/ipq4019-mbox.c | 825 +++++++++++++++++++++++++++++
> sound/soc/qcom/ipq4019/ipq4019-mbox.h | 146 +++++
> sound/soc/qcom/ipq4019/ipq4019-pcm-i2s.c | 609 +++++++++++++++++++++
> sound/soc/qcom/ipq4019/ipq4019-pcm-spdif.c | 664 +++++++++++++++++++++++
> sound/soc/qcom/ipq4019/ipq4019-pcm-tdm.c | 609 +++++++++++++++++++++
> sound/soc/qcom/ipq4019/ipq4019-pcm.h | 37 ++
> sound/soc/qcom/ipq4019/ipq4019-stereo.c | 313 +++++++++++
> sound/soc/qcom/ipq4019/ipq4019.c | 121 +++++
This is *far* too big to be a single patch. Please at the very least
split this up into one patch per driver, look at the git history of
other drivers for examples of splitting things up.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-15 12:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 7:07 [PATCH 0/4] Qualcomm IPQ4019 Audio driver addition njaigane
2016-07-15 7:07 ` [PATCH 1/4] qcom: ipq4019: Add ipq4019 ASoC device tree changes njaigane
2016-07-17 20:03 ` Rob Herring
2016-07-15 7:07 ` [PATCH 2/4] qcom: ipq4019: ASoC clock driver support njaigane
2016-08-16 1:00 ` Stephen Boyd
2016-07-15 7:07 ` [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support njaigane
2016-07-15 19:15 ` Bjorn Andersson
2016-07-15 20:23 ` Andy Gross
2016-07-15 7:07 ` [PATCH 4/4] qcom: ipq4019: Add ASoC driver modules njaigane
2016-07-15 12:52 ` Mark Brown [this message]
2016-07-15 12:56 ` [PATCH 0/4] Qualcomm IPQ4019 Audio driver addition Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715125226.GJ30372@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andy.gross@linaro.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=bselvara@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@qca.qualcomm.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=njaigane@codeaurora.org \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=pradeepb@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=snlakshm@codeaurora.org \
--cc=tiwai@suse.com \
--cc=twp@codeaurora.org \
--cc=varada@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®