From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbcGORSq (ORCPT ); Fri, 15 Jul 2016 13:18:46 -0400 Received: from smtprelay0163.hostedemail.com ([216.40.44.163]:55103 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751353AbcGORSo (ORCPT ); Fri, 15 Jul 2016 13:18:44 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3867:3868:3871:3872:3874:4321:5007:6261:7875:7901:8957:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12438:12517:12519:12663:12740:13069:13138:13231:13311:13357:13439:14181:14659:14721:21080:21324:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:10,LUA_SUMMARY:none X-HE-Tag: slope91_11be08fdb6616 X-Filterd-Recvd-Size: 1821 Date: Fri, 15 Jul 2016 13:18:40 -0400 From: Steven Rostedt To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Jiri Pirko , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH 1/3] perf script python: Fix string vs byte array resolving Message-ID: <20160715131840.3a48a0ed@gandalf.local.home> In-Reply-To: <1468567797-27564-2-git-send-email-jolsa@kernel.org> References: <1468567797-27564-1-git-send-email-jolsa@kernel.org> <1468567797-27564-2-git-send-email-jolsa@kernel.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Jul 2016 09:29:55 +0200 Jiri Olsa wrote: > + if (field->flags & FIELD_IS_STRING && > + is_printable_array(data + offset, len)) { > + obj = PyString_FromString((char *) data + offset); Hmm. As I stated, It is possible that strings can be non nul terminated. But I'm looking here and thinking we need to make sure that it is nul terminated. Can PyString_FromString() handle a non nul terminated string? -- Steve > + } else { > + obj = PyByteArray_FromStringAndSize((const char *) data + offset, len); > + field->flags &= ~FIELD_IS_STRING; > + } > } else { /* FIELD_IS_NUMERIC */ > obj = get_field_numeric_entry(event, field, data); > }