From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751909AbcGQFEs (ORCPT ); Sun, 17 Jul 2016 01:04:48 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:45218 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbcGQFEq (ORCPT ); Sun, 17 Jul 2016 01:04:46 -0400 Date: Sat, 16 Jul 2016 22:04:44 -0700 (PDT) Message-Id: <20160716.220444.1385583329528724015.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, mark.einon@gmail.com, andrew@lunn.ch, a@unstable.cc, felipe.balbi@linux.intel.com, fw@strlen.de, wuninsu@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] et131x: Fix logical vs bitwise check in et131x_tx_timeout() From: David Miller In-Reply-To: <1468626024-31534-1-git-send-email-f.fainelli@gmail.com> References: <1468626024-31534-1-git-send-email-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 16 Jul 2016 22:04:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Fri, 15 Jul 2016 16:40:22 -0700 > We should be using a logical check here instead of a bitwise operation > to check if the device is closed already in et131x_tx_timeout(). > > Reported-by: coverity (CID 146498) > Fixes: 38df6492eb511 ("et131x: Add PCIe gigabit ethernet driver et131x to drivers/net") > Signed-off-by: Florian Fainelli Applied.