From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751747AbcGPI4F (ORCPT ); Sat, 16 Jul 2016 04:56:05 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:59889 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbcGPI4C (ORCPT ); Sat, 16 Jul 2016 04:56:02 -0400 Date: Sat, 16 Jul 2016 10:55:53 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Alexey Khoroshilov Cc: Wolfram Sang , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-arm-kernel@lists.infradead.org, ldv-project@linuxtesting.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: efm32: fix a failure path in efm32_i2c_probe() Message-ID: <20160716085553.GI6040@pengutronix.de> References: <1468625798-6767-1-git-send-email-khoroshilov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1468625798-6767-1-git-send-email-khoroshilov@ispras.ru> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 16, 2016 at 02:36:38AM +0300, Alexey Khoroshilov wrote: > There is the only failure path in efm32_i2c_probe(), > where clk_disable_unprepare() is missed. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov oops, this is wrong since the beginning. Fixes: 1b5b23718b84 ("i2c: efm32: new bus driver") Acked-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |