From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751593AbcGPLtG (ORCPT <rfc822;w@1wt.eu>);
	Sat, 16 Jul 2016 07:49:06 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:52324 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751423AbcGPLtD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 16 Jul 2016 07:49:03 -0400
Date: Sat, 16 Jul 2016 12:48:58 +0100
From: Mark Brown <broonie@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Jingoo Han <jg1.han@samsung.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Vinod Koul <vinod.koul@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Wei Xu <xuwei5@hisilicon.com>,
        Rob Herring <robh+dt@kernel.org>, Andy Green <andy@warmcat.com>,
        Dave Long <dave.long@linaro.org>, Guodong Xu <guodong.xu@linaro.org>
Message-ID: <20160716114858.GQ30372@sirena.org.uk>
References: <1468635207-20065-1-git-send-email-john.stultz@linaro.org>
 <1468635207-20065-8-git-send-email-john.stultz@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="AFQGHouA0VN8Ovbt"
Content-Disposition: inline
In-Reply-To: <1468635207-20065-8-git-send-email-john.stultz@linaro.org>
X-Cookie: It's later than you think.
User-Agent: Mutt/1.6.0 (2016-04-01)
X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH 7/7] dts: hi6220: Add k3-dma and i2s/hdmi audio support
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--AFQGHouA0VN8Ovbt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 15, 2016 at 07:13:27PM -0700, John Stultz wrote:

> Add entry for k3-dma driver and i2s/hdmi audio devices.

> This enables HDMI audio output.

These bindings appear to be undocumented.  All new bindings require
documentation.

> +		i2s0: hi6210_i2s {
> +			compatible = "hisilicon,hi6210-i2s";
> +			reg = <0x0 0xf7118000 0x0 0x8000>, /* i2s unit */
> +			      <0x0 0xf7030000 0x0 0x400>,  /* syscon */
> +			      <0x0 0xf7032000 0x0 0x400>;  /* pmctrl */

Some of this looks like we should be using a system controller binding
rather than listing the system controller directly here.  The magic
number indexing for the resources is also not good, we should be using
reg-names to get name based lookups (I had been going to query that on
the binding document when I failed to find it...).

--AFQGHouA0VN8Ovbt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXih8pAAoJECTWi3JdVIfQWPAH/R23QcszYC22Uz8oJo9Fc7xu
f4HqUg7GQWWFt18OOjBCrXSNVWnFsCtIU+RreOLrbLCA2YvgwZuMWDeOPCKBd1d0
sTXelICIUNneMmb7ERToBN2lvQ9tzimbH2rl3aGxBf6sUCeER5jYwjSU9JPda+av
kqNX0rSvGr+6Gi+cSCE3Bn5O1gqAEXsZ3PHqgjzysFS6y6jDuYDK94jii+MUSpZI
64FgNtGFSWPMCt1mbXJPLfvaJLi9ltRYfWwHs0B56Jj7ryuNm8oWAxAJvxlLos33
kmUbpOsIkzudxf2nGau+dCSZQIETmhWI9IXmbDmytNdCABG3d68hjLjIWzKzDBA=
=uQjE
-----END PGP SIGNATURE-----

--AFQGHouA0VN8Ovbt--