From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751923AbcGPTZ2 (ORCPT ); Sat, 16 Jul 2016 15:25:28 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:32775 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbcGPTZZ (ORCPT ); Sat, 16 Jul 2016 15:25:25 -0400 Date: Sat, 16 Jul 2016 14:25:22 -0500 From: Rob Herring To: Stephen Boyd Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings Message-ID: <20160716192522.GA8272@rob-hp-laptop> References: <20160711190109.16758-1-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160711190109.16758-1-sboyd@codeaurora.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2016 at 12:01:09PM -0700, Stephen Boyd wrote: > The drivers don't really need to know which PMIC they're for, so > make a generic binding for them. This alleviates us from updating > the drivers every time a new PMIC comes out. It's still > recommended that we update the binding with new PMIC models and > always specify the specific model for the MPPs and gpios before > the generic compatible string in devicetree, but this at least > cuts down on adding more and more compatible strings to the > drivers until we actually need them. > > Cc: > Acked-by: "Ivan T. Ivanov" > Reviewed-by: Bjorn Andersson > Signed-off-by: Stephen Boyd > --- > > This seems to been missed 6 months ago when sent as an RFC. The dts > side changes have already been made and Rob H said it "Seems okay to > me". > > Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 5 ++++- > Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 5 ++++- > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + > drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 + > 4 files changed, 10 insertions(+), 2 deletions(-) Acked-by: Rob Herring