From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751528AbcGRGXH (ORCPT ); Mon, 18 Jul 2016 02:23:07 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:58612 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426AbcGRGWw (ORCPT ); Mon, 18 Jul 2016 02:22:52 -0400 Date: Sun, 17 Jul 2016 23:22:51 -0700 (PDT) Message-Id: <20160717.232251.1118461470001037366.davem@davemloft.net> To: tremyfr@gmail.com Cc: andrew@lunn.ch, sudipm.mukherjee@gmail.com, mugunthanvnm@ti.com, felipe.balbi@linux.intel.com, treding@nvidia.com, fw@strlen.de, linux@roeck-us.net, adi-buildroot-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net: ethernet: adi: bfin_mac: use phy_ethtool_{get|set}_link_ksettings From: David Miller In-Reply-To: <1468710615-31951-2-git-send-email-tremyfr@gmail.com> References: <1468710615-31951-1-git-send-email-tremyfr@gmail.com> <1468710615-31951-2-git-send-email-tremyfr@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 17 Jul 2016 23:22:51 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philippe Reynes Date: Sun, 17 Jul 2016 01:10:15 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > There was a check on CAP_NET_ADMIN in bfin_mac_ethtool_setsettings, > but this check is already done in dev_ethtool, so no need to repeat > it before calling the generic function. > > Signed-off-by: Philippe Reynes Applied.