From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751447AbcGQUIk (ORCPT ); Sun, 17 Jul 2016 16:08:40 -0400 Received: from spo001.leaseweb.nl ([83.149.101.17]:43765 "EHLO spo001.leaseweb.nl" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751181AbcGQUIi (ORCPT ); Sun, 17 Jul 2016 16:08:38 -0400 Date: Sun, 17 Jul 2016 22:08:36 +0200 From: Wim Van Sebroeck To: Enric Balletbo i Serra Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Martyn Welch Subject: Re: [PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading. Message-ID: <20160717200836.GI32751@spo001.leaseweb.nl> References: <1466160754-15599-1-git-send-email-enric.balletbo@collabora.com> <1466160754-15599-2-git-send-email-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466160754-15599-2-git-send-email-enric.balletbo@collabora.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric, > The I2C core removes the manufacturer prefix from the compatible field > so it reports to user-space the uevent i2c:rave-wdt, but this doesn't > match with the i2c_device_id (i2c:ziirave-wdt) array so the module is not > autoloaded. Correct the I2C device id to match with the reported uevent > and fix the module autoloading functionality. > > Signed-off-by: Enric Balletbo i Serra > --- > drivers/watchdog/ziirave_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c > index cbe373de..fa1efef 100644 > --- a/drivers/watchdog/ziirave_wdt.c > +++ b/drivers/watchdog/ziirave_wdt.c > @@ -339,7 +339,7 @@ static int ziirave_wdt_remove(struct i2c_client *client) > } > > static struct i2c_device_id ziirave_wdt_id[] = { > - { "ziirave-wdt", 0 }, > + { "rave-wdt", 0 }, > { } > }; > MODULE_DEVICE_TABLE(i2c, ziirave_wdt_id); > -- > 2.1.0 > This patch has been added to linux-watchdog-next. Kind regards, Wim.