From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751967AbcGRJGa (ORCPT ); Mon, 18 Jul 2016 05:06:30 -0400 Received: from mail.skyhub.de ([78.46.96.112]:46168 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbcGRJG1 (ORCPT ); Mon, 18 Jul 2016 05:06:27 -0400 Date: Mon, 18 Jul 2016 11:06:32 +0200 From: Borislav Petkov To: Dave Young Cc: Andrew Morton , LKML , Franck Bui , Greg Kroah-Hartman , Ingo Molnar , Linus Torvalds , Peter Zijlstra , Steven Rostedt , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Message-ID: <20160718090632.GD22689@nazgul.tnic> References: <20160715124523.GA26501@nazgul.tnic> <20160716104425.GB3031@dhcp-128-65.nay.redhat.com> <20160717054035.GA16383@nazgul.tnic> <20160718021809.GA6310@dhcp-128-65.nay.redhat.com> <20160718044407.GA20395@nazgul.tnic> <20160718052032.GA7911@dhcp-128-65.nay.redhat.com> <20160718072107.GA22689@nazgul.tnic> <20160718073845.GA9088@dhcp-128-65.nay.redhat.com> <20160718080846.GC22689@nazgul.tnic> <20160718081712.GA9239@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160718081712.GA9239@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 04:17:12PM +0800, Dave Young wrote: > Because IMHO it is wrong, they can not be ratelimited because the writing could > be from different userspace programs. It is ratelimited by interface openers. > Simply ratelimiting different sources of writing is pointless to me. So what are you arguing for? What is the *actual* *real-life* *use* case you think will be handicapped? > One can only see messages they would like to see by luck, it is worse > than off. THAT'S WHY YOU BOOT WITH "printk.devkmsg=on" TO SEE THEM ALL! The /dev/kmsg thing was added for the more or less, wrong, historic reasons and userspace started abusing it and interfering with kernel operation. That's why we're adding this tristate option. In the default case we're ratelimiting writes to it because they should not interfere with kernel operation. [ Frankly, those writes are pretty much useless to the normal user so we can just as well ignore them but WTH. ] So give me a concrete problem you see with the ralimiting and not some notion of a feeling you might have of it being pointless, ok? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --