From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Andrey Pronin <apronin@chromium.org>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
groeck@chromium.org, smbarber@chromium.org,
dianders@chromium.org
Subject: Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies
Date: Mon, 18 Jul 2016 21:45:32 +0300 [thread overview]
Message-ID: <20160718184532.GH31463@intel.com> (raw)
In-Reply-To: <1468542580-5296-1-git-send-email-apronin@chromium.org>
On Thu, Jul 14, 2016 at 05:29:40PM -0700, Andrey Pronin wrote:
> tpm_tis_core was missing conversion from msec when assigning
> max timeouts from constants.
>
> Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Fixes: 41a5e1cf1fe1
/Jarkko
> ---
> drivers/char/tpm/tpm_tis_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index 8110b52..fb8c3de 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -666,10 +666,10 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
> #endif
>
> /* Maximum timeouts */
> - chip->timeout_a = TIS_TIMEOUT_A_MAX;
> - chip->timeout_b = TIS_TIMEOUT_B_MAX;
> - chip->timeout_c = TIS_TIMEOUT_C_MAX;
> - chip->timeout_d = TIS_TIMEOUT_D_MAX;
> + chip->timeout_a = msecs_to_jiffies(TIS_TIMEOUT_A_MAX);
> + chip->timeout_b = msecs_to_jiffies(TIS_TIMEOUT_B_MAX);
> + chip->timeout_c = msecs_to_jiffies(TIS_TIMEOUT_C_MAX);
> + chip->timeout_d = msecs_to_jiffies(TIS_TIMEOUT_D_MAX);
> priv->phy_ops = phy_ops;
> dev_set_drvdata(&chip->dev, priv);
>
> --
> 2.6.6
>
next prev parent reply other threads:[~2016-07-18 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 0:29 Andrey Pronin
2016-07-15 3:06 ` Jason Gunthorpe
2016-07-18 18:45 ` Jarkko Sakkinen [this message]
2016-07-18 18:48 ` Jarkko Sakkinen
2016-07-18 18:49 ` Jason Gunthorpe
2016-07-19 12:53 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718184532.GH31463@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=apronin@chromium.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=smbarber@chromium.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome