From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbcGRTwW (ORCPT ); Mon, 18 Jul 2016 15:52:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:41355 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752401AbcGRTvv (ORCPT ); Mon, 18 Jul 2016 15:51:51 -0400 Date: Mon, 18 Jul 2016 12:51:47 -0700 From: Mark Fasheh To: Adam Borowski Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, "Darrick J . Wong" Subject: Re: [PATCH] vfs: allow FILE_EXTENT_SAME (dedupe_file_range) on a file opened ro Message-ID: <20160718195147.GD17171@wotan.suse.de> Reply-To: Mark Fasheh References: <1468793618-10496-1-git-send-email-kilobyte@angband.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468793618-10496-1-git-send-email-kilobyte@angband.pl> Organization: SUSE Labs User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 12:13:38AM +0200, Adam Borowski wrote: > Instead of checking the mode of the file descriptor, let's check whether it > could have been opened rw. This allows fixing intermittent exec failures > when deduping a live system: anyone trying to exec a file currently being > deduped gets ETXTBSY. > > Issuing this ioctl on a ro file was already allowed for root/cap. > > Tested on btrfs and not-yet-merged xfs, as only them implement this ioctl. > > Signed-off-by: Adam Borowski Reviewed-by: Mark Fasheh --Mark -- Mark Fasheh