From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbcGRXCm (ORCPT ); Mon, 18 Jul 2016 19:02:42 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59282 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbcGRXCj (ORCPT ); Mon, 18 Jul 2016 19:02:39 -0400 Date: Tue, 19 Jul 2016 00:02:34 +0100 From: Mark Brown To: Michal Suchanek Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20160718230234.GX30372@sirena.org.uk> References: <42e65e5c714f079cb4b85761e59fb700d4550a26.1468880530.git.hramrach@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GOaLjq+VdFesH+wR" Content-Disposition: inline In-Reply-To: <42e65e5c714f079cb4b85761e59fb700d4550a26.1468880530.git.hramrach@gmail.com> X-Cookie: It's later than you think. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GOaLjq+VdFesH+wR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 19, 2016 at 12:35:41AM +0200, Michal Suchanek wrote: > SPI slave devices are not created when looking up driver for the slave > fails. Create a device anyway so it can be used with spidev. > rc = of_modalias_node(nc, spi->modalias, > sizeof(spi->modalias)); > if (rc < 0) { > - dev_err(&master->dev, "cannot find modalias for %s\n", > + dev_warn(&master->dev, "cannot find modalias for %s\n", Nothing has change since you last sent this patch which converts of_modailias_node() into something which looks up a driver so the patch description still fails to describe what the patch is doing. Please don't ignore review comments, people are generally making them for a reason and are likely to have the same concerns if issues remain unaddressed. Having to repeat the same comments can get repetitive and make people question the value of time spent reviewing. If you disagree with the review comments that's fine but you need to reply and discuss your concerns so that the reviewer can understand your decisions. --GOaLjq+VdFesH+wR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXjWAKAAoJECTWi3JdVIfQMsIH/3e67YnnHrTDnjjy+Mvya7Su 8DvMmiNSvjQ675CTEVCAByjE7zudj/kAPjfboje97gSzXL1/qLaoEiFO9ruijzOF UpksstI4vgl8QRwBbalJyMG25uj+n/Wip4gTvCfvZFSQNzEtjsdjKdL3HgNN5rJO DQqqCneB2Q3zDPyMYYQ9jkjgjxk6ch73uvQyufGRxnSNEuqfcGovTdOzkj68sM5O nJXbMrnfteNaC7TdLSrWrzbZ0tlPwsukCXk3GwCa+fFXhOwO9OzoC0lW+upMaXfF W2sDz3I1KRN3JIkkReW6V0ELYIwVYLUh2PP5ENWGOlCRTo/gorb7N3f/zvNz6aI= =Wch4 -----END PGP SIGNATURE----- --GOaLjq+VdFesH+wR--