From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752379AbcGSBJg (ORCPT ); Mon, 18 Jul 2016 21:09:36 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33339 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbcGSBJd (ORCPT ); Mon, 18 Jul 2016 21:09:33 -0400 Date: Mon, 18 Jul 2016 21:09:31 -0400 From: Tejun Heo To: Topi Miettinen Cc: linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , "open list:CONTROL GROUP (CGROUP)" Subject: Re: [RFC 02/18] cgroup_pids: track maximum pids Message-ID: <20160719010931.GG3078@mtj.duckdns.org> References: <1465847065-3577-1-git-send-email-toiwoton@gmail.com> <1465847065-3577-3-git-send-email-toiwoton@gmail.com> <20160613211227.GG31708@htj.duckdns.org> <17cb1a37-47b1-dbd4-6835-efad3cf6c12f@gmail.com> <20160613213354.GH31708@htj.duckdns.org> <3b03822f-c5d0-5b84-79c3-edeb8e78e2dd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b03822f-c5d0-5b84-79c3-edeb8e78e2dd@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 17, 2016 at 08:11:31PM +0000, Topi Miettinen wrote: > On 06/13/16 21:33, Tejun Heo wrote: > > Hello, > > > > On Mon, Jun 13, 2016 at 09:29:32PM +0000, Topi Miettinen wrote: > >> I used fork callback as I don't want to lower the watermark in all cases > >> where the charge can be lowered, so I'd update the watermark only when > >> the fork really happens. > > > > I don't think that would make a noticeable difference. That's where > > we decide whether to grant fork or not after all and thus where the > > actual usage is. > > I tried using only charge functions, but then the result was too low. > With fork callback, the result was as expected. Can you please elaborate in more details? Thanks. -- tejun