From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbcGSEb4 (ORCPT ); Tue, 19 Jul 2016 00:31:56 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:54740 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbcGSEbx (ORCPT ); Tue, 19 Jul 2016 00:31:53 -0400 Date: Mon, 18 Jul 2016 21:31:52 -0700 From: Christoph Hellwig To: Arvind Yadav Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] ESIA : Dummy eisa_driver_register should return error code Message-ID: <20160719043152.GA27579@infradead.org> References: <1468867501-19054-1-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468867501-19054-1-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2016 at 12:15:01AM +0530, Arvind Yadav wrote: > The inline eisa_driver_register stub simply allows compilation on > systems with CONFIG_EISA disabled. the dummy eisa_driver_register > does not register an *_eisa_driver at all. The inline > eisa_driver_register should return to indicate lack of support > when attempting to register an *_eisa_driver on such a system with > CONFIG_EISA disabled. Why? The idea is that you can simply leave the stub in if registering say PCI / EISA. With your change such a driver will fail to load even if it could serve PCI device in a !CONFIG_EISA config, which is the behavior we want.