From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752623AbcGSGk2 (ORCPT ); Tue, 19 Jul 2016 02:40:28 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:55916 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585AbcGSGkC (ORCPT ); Tue, 19 Jul 2016 02:40:02 -0400 Date: Tue, 19 Jul 2016 08:39:55 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Brian Norris Cc: Heiko Stuebner , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Brian Norris , linux-arm-kernel@lists.infradead.org, Caesar Wang Subject: Re: [PATCH] arm64: dts: rockchip: add spiX aliases for rk3399 Message-ID: <20160719063955.GE5368@pengutronix.de> References: <1468545873-134339-1-git-send-email-briannorris@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1468545873-134339-1-git-send-email-briannorris@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Jul 14, 2016 at 06:24:33PM -0700, Brian Norris wrote: > It's nicer to see this: > > # ls -l /sys/bus/spi/devices/ > total 0 > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi0.0 -> ../../../devices/platform/ff1c0000.spi/spi_master/spi0/spi0.0 > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi1.0 -> ../../../devices/platform/ff1d0000.spi/spi_master/spi1/spi1.0 > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi2.0 -> ../../../devices/platform/ff1e0000.spi/spi_master/spi2/spi2.0 > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi5.0 -> ../../../devices/platform/ff200000.spi/spi_master/spi5/spi5.0 > > than this: > > # ls -l /sys/bus/spi/devices/ > total 0 > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32763.0 -> ../../../devices/platform/ff200000.spi/spi_master/spi32763/spi32763.0 > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32764.0 -> ../../../devices/platform/ff1e0000.spi/spi_master/spi32764/spi32764.0 > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32765.0 -> ../../../devices/platform/ff1d0000.spi/spi_master/spi32765/spi32765.0 > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32766.0 -> ../../../devices/platform/ff1c0000.spi/spi_master/spi32766/spi32766.0 > > With the latter, it's much clearer which bus devices are on. > > Signed-off-by: Brian Norris > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 4c84229789ef..b04abbfd4898 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -70,6 +70,12 @@ > serial2 = &uart2; > serial3 = &uart3; > serial4 = &uart4; > + spi0 = &spi0; > + spi1 = &spi1; > + spi2 = &spi2; > + spi3 = &spi3; > + spi4 = &spi4; > + spi5 = &spi5; Note that Rob Herring (with his dt-maintainer hat on) doesn't like these aliases. See for example: http://mid.gmane.org/20160705140546.GA10601@rob-hp-laptop Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |