From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752978AbcGSHHS (ORCPT ); Tue, 19 Jul 2016 03:07:18 -0400 Received: from mga03.intel.com ([134.134.136.65]:49963 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752519AbcGSHHQ (ORCPT ); Tue, 19 Jul 2016 03:07:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,388,1464678000"; d="scan'208";a="998050144" Date: Tue, 19 Jul 2016 10:07:05 +0300 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: Crestez Dan Leonard , ACPI Devel Maling List , "Rafael J. Wysocki" , Jarkko Nikula , Len Brown , linux-i2c , Wolfram Sang , linux-spi , Mark Brown , Linux Kernel Mailing List , Octavian Purdila Subject: Re: [PATCH v2 2/3] acpi i2c: Initialize info.type from of_compatible Message-ID: <20160719070705.GN14693@lahna.fi.intel.com> References: <4b9ea75003d78406307cbb392150fb038b1b72f7.1468409668.git.leonard.crestez@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2016 at 02:20:57PM +0200, Rafael J. Wysocki wrote: > On Wed, Jul 13, 2016 at 1:53 PM, Crestez Dan Leonard > wrote: > > When using devicetree i2c_board_info.type is set to the compatible > > string with the vendor prefix removed. For I2C devices described via > > ACPI the i2c_board_info.type string is set to the ACPI device name. When > > using ACPI and DT ids this string ends up something like "PRP0001:00". > > > > If the of_compatible property is present try to use that instead. This > > makes it easier to instantiate i2c drivers through ACPI with DT ids. > > > > Signed-off-by: Crestez Dan Leonard > > Looks good to me, but Mika needs to have a look at it too. Looks good to me, Reviewed-by: Mika Westerberg