From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752897AbcGSJK6 (ORCPT ); Tue, 19 Jul 2016 05:10:58 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:32826 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbcGSJK4 (ORCPT ); Tue, 19 Jul 2016 05:10:56 -0400 Date: Tue, 19 Jul 2016 11:10:53 +0200 From: Michal Hocko To: Naoya Horiguchi Cc: Andrew Morton , Zhan Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Naoya Horiguchi Subject: Re: [PATCH v1] mm: hugetlb: remove incorrect comment Message-ID: <20160719091052.GC9490@dhcp22.suse.cz> References: <1468894098-12099-1-git-send-email-n-horiguchi@ah.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468894098-12099-1-git-send-email-n-horiguchi@ah.jp.nec.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 19-07-16 11:08:18, Naoya Horiguchi wrote: > dequeue_hwpoisoned_huge_page() can be called without page lock hold, > so let's remove incorrect comment. Could you explain why the page lock is not really needed, please? Or what has changed that it is not needed anymore? Thanks! > > Reported-by: Zhan Chen > Signed-off-by: Naoya Horiguchi > --- > mm/hugetlb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git v4.7-rc7/mm/hugetlb.c v4.7-rc7_patched/mm/hugetlb.c > index c1f3c0b..26f735c 100644 > --- v4.7-rc7/mm/hugetlb.c > +++ v4.7-rc7_patched/mm/hugetlb.c > @@ -4401,7 +4401,6 @@ follow_huge_pud(struct mm_struct *mm, unsigned long address, > > /* > * This function is called from memory failure code. > - * Assume the caller holds page lock of the head page. > */ > int dequeue_hwpoisoned_huge_page(struct page *hpage) > { > -- > 2.7.0 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs