From: Mark Brown <broonie@kernel.org>
To: Michal Suchanek <hramrach@gmail.com>
Cc: linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver
Date: Tue, 19 Jul 2016 11:52:12 +0100 [thread overview]
Message-ID: <20160719105212.GA30372@sirena.org.uk> (raw)
In-Reply-To: <CAOMqctS0+eaufGdsGV96h3SJCOGrjhaAL1aRxxkMRtpK_p_3YQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]
On Tue, Jul 19, 2016 at 10:31:54AM +0200, Michal Suchanek wrote:
> On 19 July 2016 at 01:02, Mark Brown <broonie@kernel.org> wrote:
> > On Tue, Jul 19, 2016 at 12:35:41AM +0200, Michal Suchanek wrote:
> >> SPI slave devices are not created when looking up driver for the slave
> >> fails. Create a device anyway so it can be used with spidev.
> > Nothing has change since you last sent this patch which converts
> > of_modailias_node() into something which looks up a driver so the
> > patch description still fails to describe what the patch is doing.
> I have split the other part of the patch. Regarding the commit message
> if you have suggestion for better wording please do share it.
As covered in SubmittingPatches your commit message should describe what
the change does and what the intended effect is. If we were looking for
a device driver the code would be looking up a struct device_driver or
some other struct that contains one.
> From my point of view the conceptual change described in the commit message
> is that whenever SPI slave node is encountered in devicetree you get either
> a device with active driver or a device with no driver whereas
> previously you either
> got a device with active driver or no device. So yes, it's about
This is not the case, it is perfectly possible to have a device with no
driver bound to it otherwise it would not be possible to use loadable
modules for drivers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-19 10:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 22:35 [PATCH v3 0/3] Spidev usability patchset update Michal Suchanek
2016-07-18 22:35 ` [PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves Michal Suchanek
2016-07-18 22:59 ` Mark Brown
2016-07-19 11:17 ` Michal Suchanek
2016-07-19 12:44 ` Mark Brown
2016-07-19 15:32 ` Michal Suchanek
2016-07-19 17:19 ` Mark Brown
2016-07-19 18:33 ` Michal Suchanek
2016-07-27 18:27 ` Mark Brown
2016-07-20 7:16 ` [lkp] " Fengguang Wu
2016-07-18 22:35 ` [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver Michal Suchanek
2016-07-18 23:02 ` Mark Brown
2016-07-19 8:31 ` Michal Suchanek
2016-07-19 10:52 ` Mark Brown [this message]
2016-07-30 17:45 ` Michal Suchanek
2016-07-18 22:35 ` [PATCH v3 3/3] spi: core: allow creating devices without spi-max-frequency Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719105212.GA30372@sirena.org.uk \
--to=broonie@kernel.org \
--cc=hramrach@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome