From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753911AbcGSOSA (ORCPT ); Tue, 19 Jul 2016 10:18:00 -0400 Received: from foss.arm.com ([217.140.101.70]:36480 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753385AbcGSOR6 (ORCPT ); Tue, 19 Jul 2016 10:17:58 -0400 Date: Tue, 19 Jul 2016 15:17:49 +0100 From: Catalin Marinas To: David Long Cc: Mark Rutland , Yang Shi , Zi Shen Lim , Will Deacon , Andrey Ryabinin , yalin wang , Li Bin , Jisheng Zhang , John Blackwood , Pratyush Anand , Daniel Thompson , Huang Shijie , Dave P Martin , Petr Mladek , Vladimir Murzin , Steve Capper , Suzuki K Poulose , Marc Zyngier , Mark Brown , Sandeepa Prabhu , William Cohen , Alex =?iso-8859-1?Q?Benn=E9e?= , Adam Buchbinder , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , linux-kernel@vger.kernel.org, James Morse , Masami Hiramatsu , Andrew Morton , Robin Murphy , Jens Wiklander , Christoffer Dall Subject: Re: [PATCH v15 01/10] arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature Message-ID: <20160719141749.GC21256@e104818-lin.cambridge.arm.com> References: <1467995754-32508-1-git-send-email-dave.long@linaro.org> <1467995754-32508-2-git-send-email-dave.long@linaro.org> <20160715105701.GB14792@e104818-lin.cambridge.arm.com> <5788F86B.60305@linaro.org> <20160715150532.GA22563@localhost> <57892286.1040609@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57892286.1040609@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2016 at 01:51:02PM -0400, David Long wrote: > On 07/15/2016 11:13 AM, Catalin Marinas wrote: > >On Fri, Jul 15, 2016 at 10:51:23AM -0400, David Long wrote: > >>On 07/15/2016 06:57 AM, Catalin Marinas wrote: > >>>On Fri, Jul 08, 2016 at 12:35:45PM -0400, David Long wrote: > >>>>+extern bool regs_within_kernel_stack(struct pt_regs *regs, unsigned long addr); > >>> > >>>This one only seems to be used in arch/arm64/kernel/ptrace.c. Can we > >>>make it static and remove the declaration? > >> > >>OK. > > > >I can change it locally. > > It's looking like there will need to be another iteration of the patch for a > few small things anyway, although those changes could also be done as > subsequent improvements. I've pushed the branch below with my fixups on this series. Please post any minor changes you have as additional patches on top. Thanks. git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/kprobes -- Catalin