From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753085AbcGSMWv (ORCPT ); Tue, 19 Jul 2016 08:22:51 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38579 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752791AbcGSMWu (ORCPT ); Tue, 19 Jul 2016 08:22:50 -0400 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: cornelia.huck@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 19 Jul 2016 14:22:43 +0200 From: Cornelia Huck To: Minfei Huang Cc: mst@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, fanc.fnst@cn.fujitsu.com, Minfei Huang , Minfei Huang Subject: Re: [PATCH v3] virtio_blk: Fix a slient kernel panic In-Reply-To: <1468902762-43268-1-git-send-email-mnfhuang@gmail.com> References: <1468902762-43268-1-git-send-email-mnfhuang@gmail.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16071912-0032-0000-0000-000001EB7C86 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16071912-0033-0000-0000-00001BEAF9FD Message-Id: <20160719142243.1c62ac03.cornelia.huck@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-19_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607190133 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jul 2016 12:32:42 +0800 Minfei Huang wrote: > From: Minfei Huang > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to lacking memory. At that moment, > kernel will panic in guest machine, if virtio is used to drive disk. > > To fix this bug, we should take care of allocation failure, and return > correct value to let caller know what happen. > > Tested-by: Chao Fan > Signed-off-by: Minfei Huang > Signed-off-by: Minfei Huang > --- > v2: > - Remove useless initialisation to NULL > v1: > - Refactor the patch to make code more readable > --- > drivers/block/virtio_blk.c | 26 ++++++++------------------ > 1 file changed, 8 insertions(+), 18 deletions(-) Your changes certainly make the function more compact. Reviewed-by: Cornelia Huck