From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751572AbcGTEPQ (ORCPT ); Wed, 20 Jul 2016 00:15:16 -0400 Received: from mail1.windriver.com ([147.11.146.13]:34668 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbcGTEOd (ORCPT ); Wed, 20 Jul 2016 00:14:33 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Linus Walleij , Alexandre Courbot , , , Subject: [PATCH 3/3] ARM: pxa: add module.h for spitz symbol_get/symbol_put usage Date: Wed, 20 Jul 2016 00:13:32 -0400 Message-ID: <20160720041332.30789-4-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.8.4 In-Reply-To: <20160720041332.30789-1-paul.gortmaker@windriver.com> References: <20160720041332.30789-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During unrelated work, attempting to remove an include of the linux/module.h in favour of "struct module;" in order to reduce header entanglement, we found doing so caused a build failure in this file. mach-pxa/spitz.c: In function 'spitz_bl_kick_battery': mach-pxa/spitz.c:524:2: error: implicit declaration of function 'symbol_get' [-Werror=implicit-function-declaration] mach-pxa/spitz.c:524:12: warning: assignment makes pointer from integer without a cast [enabled by default] mach-pxa/spitz.c:527:3: error: implicit declaration of function 'symbol_put' [-Werror=implicit-function-declaration] It turns out this file uses symbol_get/symbol_put which live in the module.h header, but it wasn't including module.h -- which was being masked by the module.h in include/linux/gpio/driver.h - the one we want to remove/replace. With ARM and GPIO being different subsystems, we'll need to get this in ARM 1st, and then wait a release before changing the GPIO header, otherwise we'll risk triggering build failures. Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Cc: Russell King Cc: Linus Walleij Cc: Alexandre Courbot Cc: linux-omap@vger.kernel.org Cc: linux-gpio@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Paul Gortmaker --- arch/arm/mach-pxa/spitz.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c index b410698808ca..8078e3cdb6c8 100644 --- a/arch/arm/mach-pxa/spitz.c +++ b/arch/arm/mach-pxa/spitz.c @@ -13,6 +13,7 @@ */ #include +#include /* symbol_get ; symbol_put */ #include #include #include -- 2.8.4