From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248AbcGTDSV (ORCPT ); Tue, 19 Jul 2016 23:18:21 -0400 Received: from ozlabs.org ([103.22.144.67]:36031 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbcGTDSS (ORCPT ); Tue, 19 Jul 2016 23:18:18 -0400 Date: Wed, 20 Jul 2016 13:18:14 +1000 From: Stephen Rothwell To: Arnaldo Carvalho de Melo Cc: Andy Lutomirski , Arnaldo Carvalho de Melo , Josh Poimboeuf , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH/RFC] Re: linux-next: build failure after merge of the luto-misc tree Message-ID: <20160720131814.7fd4abd9@canb.auug.org.au> In-Reply-To: <20160720030923.GC2408@redhat.com> References: <20160718234132.GI2207@kernel.org> <20160719102629.0a12a1a1@canb.auug.org.au> <20160719003906.GJ2207@kernel.org> <20160719132608.1aa2692a@canb.auug.org.au> <20160719125443.GL2207@kernel.org> <20160719174551.GM2207@kernel.org> <20160720092157.7cd8de65@canb.auug.org.au> <20160720095333.3034531c@canb.auug.org.au> <20160720025202.GB18962@kernel.org> <20160720030923.GC2408@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Wed, 20 Jul 2016 00:09:24 -0300 Arnaldo Carvalho de Melo wrote: > > Em Tue, Jul 19, 2016 at 07:57:24PM -0700, Andy Lutomirski escreveu: > > On Tue, Jul 19, 2016 at 7:52 PM, Arnaldo Carvalho de Melo > > wrote: > > > Em Wed, Jul 20, 2016 at 09:53:33AM +1000, Stephen Rothwell escreveu: > > >> On Wed, 20 Jul 2016 09:21:57 +1000 Stephen Rothwell wrote: > > >> > On Tue, 19 Jul 2016 14:45:51 -0300 Arnaldo Carvalho de Melo wrote: > > >> > > #if BITS_PER_LONG != __BITS_PER_LONG > > >> > > +#include > > >> > > +#pragma message "BITS_PER_LONG=" __stringify(BITS_PER_LONG) > > >> > > +#pragma message "__BITS_PER_LONG=" __stringify(__BITS_PER_LONG) > > >> > > #error Inconsistent word size. Check asm/bitsperlong.h > > >> > > #endif > > > > > >> > I added those three lines to the file (just in yesterday's linux-next > > >> > was easiest) and got this: > > > > > >> > /home/sfr/next/next/tools/include/asm-generic/bitsperlong.h:14:9: note: #pragma message: BITS_PER_LONG=(8 * 8) > > >> > #pragma message "BITS_PER_LONG=" __stringify(BITS_PER_LONG) > > > > > >> > /home/sfr/next/next/tools/include/asm-generic/bitsperlong.h:15:9: note: #pragma message: __BITS_PER_LONG=32 > > >> > #pragma message "__BITS_PER_LONG=" __stringify(__BITS_PER_LONG) > > > > > >> > (a few times, of course) > > > > > >> So I applied this: > > > > > >> +++ b/tools/arch/x86/include/uapi/asm/bitsperlong.h > > >> @@ -4,6 +4,12 @@ > > >> #if defined(__x86_64__) && !defined(__ILP32__) > > >> # define __BITS_PER_LONG 64 > > >> #else > > >> +#ifndef __x86_64__ > > >> +#pragma message "__x86_64__ is not defined" > > >> +#endif > > >> +#ifdef __ILP32__ > > >> +#pragma message "__ILP32__ is defined" > > >> +#endif > > >> # define __BITS_PER_LONG 32 > > >> #endif > > > > > >> and got this: > > > > > >> /home/sfr/next/next/tools/arch/x86/include/uapi/asm/bitsperlong.h:8:9: note: #pragma message: __x86_64__ is not defined > > >> #pragma message "__x86_64__ is not defined" > > > > > > Humm, it seems that the compiler used is not the cross one, but the > > > native, check if, say, __powerpc__ is defined. > > > > > > > This is still vdso2c, right? It's a hostprog. > > > > This stuff is utterly screwed up. We're building a hostprog for an > > x86_64 kernel cross-compiled from powerpc. We should presumably be > > pullng in powerpc's uapi headers for hostprogs because it's a *host* > > prog. > > Unsure, I thought that what was breaking was objtool (tools/objtool), > Stephen? Yes, it is objtool, but that is also a host program and so should be using the host architectures includes, right? Thanks for pointing that out Andy, -- Cheers, Stephen Rothwell