From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754991AbcGTRFC (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Jul 2016 13:05:02 -0400
Received: from foss.arm.com ([217.140.101.70]:43705 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754795AbcGTREl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Jul 2016 13:04:41 -0400
Date: Wed, 20 Jul 2016 18:04:33 +0100
From: Catalin Marinas <catalin.marinas@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Petr Mladek <pmladek@suse.com>,
        Zi Shen Lim <zlim.lnx@gmail.com>, Will Deacon <will.deacon@arm.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        yalin wang <yalin.wang2010@gmail.com>,
        Li Bin <huawei.libin@huawei.com>,
        John Blackwood <john.blackwood@ccur.com>,
        Pratyush Anand <panand@redhat.com>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        David Long <dave.long@linaro.org>, Huang Shijie <shijie.huang@arm.com>,
        Dave P Martin <Dave.Martin@arm.com>,
        Jisheng Zhang <jszhang@marvell.com>,
        Vladimir Murzin <Vladimir.Murzin@arm.com>,
        Steve Capper <steve.capper@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Yang Shi <yang.shi@linaro.org>, Mark Brown <broonie@kernel.org>,
        Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
        William Cohen <wcohen@redhat.com>,
        Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support
Message-ID: <20160720170432.GH25890@e104818-lin.cambridge.arm.com>
References: <1467995754-32508-1-git-send-email-dave.long@linaro.org>
 <1467995754-32508-5-git-send-email-dave.long@linaro.org>
 <578FA238.3050206@arm.com>
 <20160720162827.GF25890@e104818-lin.cambridge.arm.com>
 <578FAB02.90707@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <578FAB02.90707@arm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 20, 2016 at 05:46:58PM +0100, Marc Zyngier wrote:
> From 0d120f95b3348e1946d8a789c7147f316c27ea6b Mon Sep 17 00:00:00 2001
> From: Marc Zyngier <marc.zyngier@arm.com>
> Date: Wed, 20 Jul 2016 17:36:42 +0100
> Subject: [PATCH] arm64: kprobes: Fix overflow when saving stack
> 
> The MIN_STACK_SIZE macro tries evaluate how much stack space needs
> to be saved in the jprobes_stack array, sized at 128 bytes.
> 
> When using the IRQ stack, said macro can happily return up to
> IRQ_STACK_SIZE, which is 16kB. Mayhem follows.
> 
> This patch fixes things by getting rid of the crazy macro and
> limiting the copy to be at most the size of the jprobes_stack
> array, no matter which stack we're on.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

Applied to the kprobes branch. Thanks.

(I can't yet tell whether kprobes will make into 4.8; I need to run some
more tests before deciding)

-- 
Catalin