From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755550AbcGTXIg (ORCPT ); Wed, 20 Jul 2016 19:08:36 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:48664 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751838AbcGTXId (ORCPT ); Wed, 20 Jul 2016 19:08:33 -0400 Date: Thu, 21 Jul 2016 02:08:29 +0300 From: Sakari Ailus To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Marek Szyprowski , Mauro Carvalho Chehab , Kyungmin Park , Pawel Osciak , linux-media@vger.kernel.org Subject: Re: [PATCH v2] [media] vb2: include lengths in dmabuf qbuf debug message Message-ID: <20160720230829.GH7976@valkosipuli.retiisi.org.uk> References: <1469030875-2246-1-git-send-email-javier@osg.samsung.com> <20160720195228.GD7976@valkosipuli.retiisi.org.uk> <75cf608c-d5a5-420e-2a37-dfef9891dbdc@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75cf608c-d5a5-420e-2a37-dfef9891dbdc@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On Wed, Jul 20, 2016 at 06:56:52PM -0400, Javier Martinez Canillas wrote: > Hello Sakari, > > On 07/20/2016 03:52 PM, Sakari Ailus wrote: > > On Wed, Jul 20, 2016 at 12:07:55PM -0400, Javier Martinez Canillas wrote: > >> If the VIDIOC_QBUF ioctl fails due a wrong dmabuf length, it's > >> useful to get the invalid and minimum lengths as a debug info. > >> > >> Before this patch: > >> > >> vb2-core: __qbuf_dmabuf: invalid dmabuf length for plane 1 > >> > >> After this patch: > >> > >> vb2-core: __qbuf_dmabuf: invalid dmabuf length 221248 for plane 1, minimum length 410880 > >> > >> Signed-off-by: Javier Martinez Canillas > >> > >> --- > >> > >> Changes in v2: > >> - Use %u instead of %d (Sakari Ailus) > >> - Include min_length (Sakari Ailus) > >> > >> drivers/media/v4l2-core/videobuf2-core.c | 6 ++++-- > >> 1 file changed, 4 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c > >> index b6fbc04f9699..bbba50d6e1ad 100644 > >> --- a/drivers/media/v4l2-core/videobuf2-core.c > >> +++ b/drivers/media/v4l2-core/videobuf2-core.c > >> @@ -1227,8 +1227,10 @@ static int __qbuf_dmabuf(struct vb2_buffer *vb, const void *pb) > >> planes[plane].length = dbuf->size; > >> > >> if (planes[plane].length < vb->planes[plane].min_length) { > >> - dprintk(1, "invalid dmabuf length for plane %d\n", > >> - plane); > >> + dprintk(1, "invalid dmabuf length %u for plane %d, " > >> + "minimum length %u\n", > > > > You shouldn't split strings. It breaks grep. > > > > Yes I know but if I didn't split the line, it would had been longer than > the max 80 character per line convention. On those situations I follow > what's already done in the file for consistency and most strings in the > videobuf2-core file, whose lines are over 80 characters, are being split. > > But if having a longer line is preferred, I'll happily re-spin the patch. I guess in videobuf2's case it's that the strings contain lots of format specifiers --- it's not that useful to be able to grep those. I think this case is a borderline one. Up to you. You've got my ack. > > With that changed, > > > > Acked-by: Sakari Ailus > > > >> + planes[plane].length, plane, > >> + vb->planes[plane].min_length); > >> dma_buf_put(dbuf); > >> ret = -EINVAL; > >> goto err; > > > > Best regards, > -- > Javier Martinez Canillas > Open Source Group > Samsung Research America -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk