From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932393AbcGTXP3 (ORCPT ); Wed, 20 Jul 2016 19:15:29 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:47606 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932154AbcGTXP1 (ORCPT ); Wed, 20 Jul 2016 19:15:27 -0400 Date: Thu, 21 Jul 2016 08:15:24 +0900 From: Simon Horman To: Geert Uytterhoeven Cc: Arnd Bergmann , Magnus Damm , Linux-Renesas , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ARM: shmobile: don't call platform_can_secondary_boot on UP Message-ID: <20160720231523.GD9599@verge.net.au> References: <20160630122529.4031024-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2016 at 03:09:46PM +0200, Geert Uytterhoeven wrote: > Hi Arnd, > > On Thu, Jun 30, 2016 at 2:25 PM, Arnd Bergmann wrote: > > For rcar-gen2, we build the SMP files even for UP configurations, > > and that just broke: > > > > arch/arm/mach-shmobile/built-in.o: In function `shmobile_smp_init_fallback_ops': > > pm-rcar-gen2.c:(.init.text+0x40c): undefined reference to `platform_can_secondary_boot' > > > > This adds an compile-time check before the call to platform_can_secondary_boot, > > turning the function into an empty stub for UP configurations. > > > > Signed-off-by: Arnd Bergmann > > Fixes: c21af444eace ("ARM: shmobile: smp: Add function to prioritize DT SMP") > > Crap, I think I took the shortcut of only compile-testing > arch/arm/mach-shmobile, > not link-testing the whole kernel, with CONFIG_SMP=n... > > Acked-by: Geert Uytterhoeven Sorry for missing this until now. I have queued it up as a fix for v4.7.