From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753449AbcGUAUD (ORCPT ); Wed, 20 Jul 2016 20:20:03 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:36038 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753370AbcGUAUA (ORCPT ); Wed, 20 Jul 2016 20:20:00 -0400 X-AuditID: cbfee68e-f79266d000001428-9f-5790152e7f8b Date: Thu, 21 Jul 2016 09:19:57 +0900 From: Andi Shyti To: Sean Young Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [RFC 1/7] [media] rc-main: assign driver type during allocation Message-id: <20160721001957.GD23521@samsunx.samsung> References: <1468943818-26025-1-git-send-email-andi.shyti@samsung.com> <1468943818-26025-2-git-send-email-andi.shyti@samsung.com> <20160719220447.GA24697@gofer.mess.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <20160719220447.GA24697@gofer.mess.org> User-Agent: Mutt/1.6.0 (2016-04-01) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsWyRsSkQFdPdEK4wZFDPBaLfzxnsri8aw6b Rc+GrawWq59VWCx8+p3FgdXj+pJPzB5L3lh7bOm/y+7xeZNcAEsUl01Kak5mWWqRvl0CV8br k3NZC56yVVx5vpytgXEZaxcjJ4eEgIlE3/SzbBC2mMSFe+uBbC4OIYEVjBLLt11nhim63biS FSIxi1Fi+q1pjBDOR0aJO7cvsoNUsQioSrxedh6sg01AU6Lp9g+wsSICchLftrWAdTMLTGSU eNTfyQKSEBbwkVix8gKYzQu0Yub/vcwQUxuZJK7+WcQMkRCU+DH5HlgRs4CWxPqdx5kgbGmJ R39ngG3mBGle+xnoJA4OUQFlibvLgkDmSAhsY5c4OfEvC8R1AhLfJh9iAamREJCV2HQA6jVJ iYMrbrBMYBSbhWTbLCTbZiHZtoCReRWjaGpBckFxUnqRkV5xYm5xaV66XnJ+7iZGYGSd/ves bwfjzQPWhxgFOBiVeHgF1vWHC7EmlhVX5h5iNAW6YiKzlGhyPjB+80riDY3NjCxMTUyNjcwt zZTEeROkfgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYAw/cfNEr9cSz1VhvDtyPWcd4q26 1flDyO2lf+DBibW3zQ+91Y/O2GSrWqz4+jtfSZKhxhbn09OuVjVPYDWK3nD2UkaL3LwEpbmv FJbpfGp8/3vvutsNJa8svu6/fLRdef1d5q9KVUkHNPIab4vtXndkiiub/Ibj5wRsww5o/3NS Xsm6WznMXkyJpTgj0VCLuag4EQB3Tp/ipwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jQV090QnhBk/2sVss/vGcyeLyrjls Fj0btrJarH5WYbHw6XcWB1aP60s+MXsseWPtsaX/LrvH501yASxRDYw2GamJKalFCql5yfkp mXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUBrlRTKEnNKgUIBicXFSvp2mCaE hrjpWsA0Ruj6hgTB9RgZoIGENYwZr0/OZS14ylZx5flytgbGZaxdjJwcEgImErcbV0LZYhIX 7q1n62Lk4hASmMUoMf3WNEYI5yOjxJ3bF9lBqlgEVCVeLzvPDGKzCWhKNN3+wQZiiwjISXzb 1sIK0sAsMJFR4lF/JwtIQljAR2LFygtgNi/Qupn/9zJDTG1kkrj6ZxEzREJQ4sfke2BFzAJa Eut3HmeCsKUlHv2dAbaZE6R57Wegkzg4RAWUJe4uC5rACHQnQvcsJN2zkHQvYGRexSiRWpBc UJyUnmuYl1quV5yYW1yal66XnJ+7iREcvc+kdjAe3OV+iFGAg1GJh1eBfUK4EGtiWXFl7iFG CQ5mJRFeHRGgEG9KYmVValF+fFFpTmrxIUZTYIhMZJYSTc4HJpa8knhDYxMzI0sjc0MLI2Nz JXHex//XhQkJpCeWpGanphakFsH0MXFwSjUw6k3d5RChfedFigCvZ+Ay1lutaQ1nlk62Y71r omRyUXZip1BM/3lOCe7l65Q+LN1Xue64uuEUy9gZe3/ta7d73RXRWpO0Ineqjt/iRo2yDzyH I8o9qtS/Lj/8tEGUsez8xfylvOG2x9k5TNU8ph4w2sF8/fmCxUsKN69aI+0+OdT0oGHmvgl7 lFiKMxINtZiLihMBQgkar/QCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sean, > > The driver type can be assigned immediately when an RC device > > requests to the framework to allocate the device. > > > > This is an 'enum rc_driver_type' data type and specifies whether > > the device is a raw receiver or scancode receiver. The type will > > be given as parameter to the rc_allocate_device device. > > This patch is good, but it does unfortunately break all the other > rc-core drivers, as now rc_allocate_device() needs argument. All > drivers will need a simple change in this patch. Yes, but for being an RFC I didn't took care of fixing everything. > Also note that there lots of issues that checkpatch.pl would pick > in these series. Some of the issues are coming from the code as it was and I preferred to not change it. The last patch has some that need to be fixed in the patchset. Thanks, Andi