From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbcGUAoT (ORCPT ); Wed, 20 Jul 2016 20:44:19 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:48216 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbcGUAoR (ORCPT ); Wed, 20 Jul 2016 20:44:17 -0400 X-AuditID: cbfee68e-f79266d000001428-4f-57901ade1098 Date: Thu, 21 Jul 2016 09:44:14 +0900 From: Andi Shyti To: Sean Young Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [RFC 3/7] [media] rc-core: add support for IR raw transmitters Message-id: <20160721004414.GE23521@samsunx.samsung> References: <1468943818-26025-1-git-send-email-andi.shyti@samsung.com> <1468943818-26025-4-git-send-email-andi.shyti@samsung.com> <20160719221027.GB24697@gofer.mess.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <20160719221027.GB24697@gofer.mess.org> User-Agent: Mutt/1.6.0 (2016-04-01) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsWyRsSkUPee1IRwg6MvrCwW/3jOZHF51xw2 i54NW1ktVj+rsFj49DuLA6vH9SWfmD2WvLH22NJ/l93j8ya5AJYoLpuU1JzMstQifbsEroxL N7ezFVxlrZh2ZRVjA+NWli5GTg4JAROJ/0uuMkHYYhIX7q1n62Lk4hASWMEocWvKc1aYoo/P XrNAJJYySvzpPM4M4XxklLg/byUjSBWLgKrErVkvwUaxCWhKNN3+wQZiiwjISXzb1sIK0sAs MJFR4lF/J9huYQFvid8d89hBbF6gFZ3XprNCTG1kkjjy9i8rREJQ4sfke2ANzAJaEut3HmeC sKUlHv2dAdbMCdT8ZMl8oG0cHKICyhJ3lwWBzJEQ2MUucXDyKjaI6wQkvk0+xAJSIyEgK7Hp ADPEa5ISB1fcYJnAKDYLybZZSLbNQrJtASPzKkbR1ILkguKk9CIjveLE3OLSvHS95PzcTYzA yDr971nfDsabB6wPMQpwMCrx8Aqs6w8XYk0sK67MPcRoCnTFRGYp0eR8YPzmlcQbGpsZWZia mBobmVuaKYnzJkj9DBYSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAGB7dvP6reZ9knPPMhxWW HSyXn6TfvzjHRHXP3GhXm9e9AZzBhm+zXm67yLH79WNGVe9ndrfXMWpkZ+iaFYft4Y8M184T mxzx9cqZ2T+fWt+fZt6b6OvJxbTon3rNV421366kpNjtPnbhT/iKQtscQ6U1wgr7Q0/tTkw5 cfGC9TzBTvGrd3ULlViKMxINtZiLihMBiMt1rqcCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jAd17UhPCDfrmmVks/vGcyeLyrjls Fj0btrJarH5WYbHw6XcWB1aP60s+MXsseWPtsaX/LrvH501yASxRDYw2GamJKalFCql5yfkp mXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUBrlRTKEnNKgUIBicXFSvp2mCaE hrjpWsA0Ruj6hgTB9RgZoIGENYwZl25uZyu4ylox7coqxgbGrSxdjJwcEgImEh+fvYayxSQu 3FvP1sXIxSEksJRR4k/ncWYI5yOjxP15KxlBqlgEVCVuzXrJBGKzCWhKNN3+wQZiiwjISXzb 1sIK0sAsMJFR4lF/J9hYYQFvid8d89hBbF6gdZ3XprNCTG1kkjjy9i8rREJQ4sfke2ANzAJa Eut3HmeCsKUlHv2dAdbMCdT8ZMl8oG0cHKICyhJ3lwVNYBSYhaR7FpLuWUi6FzAyr2KUSC1I LihOSs81ykst1ytOzC0uzUvXS87P3cQIjt5n0jsYD+9yP8QowMGoxMO7Y3V/uBBrYllxZe4h RgkOZiURXh2RCeFCvCmJlVWpRfnxRaU5qcWHGE2BITKRWUo0OR+YWPJK4g2NTcyMLI3MDS2M jM2VxHkf/18XJiSQnliSmp2aWpBaBNPHxMEp1cC4+EVzkKxjReaT88nSisHvNy0/VLdCvd14 Qn7bQmuHiqaXp26m96sVRM7UWp+7y+HvToMp0eeel1gEp1y8/rQxWui/U8prlau5y5Xjzj19 frHeVuX+5HfH1vcc+lvGkOXSXpW/bUL8zlOZj0N9fzLwPmLwfqY6ef3Dwi8lq9Wr1r1/c0Ru eZOaEktxRqKhFnNRcSIAcNicl/QCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sean, > > + if (dev->driver_type == RC_DRIVER_IR_RAW || > > + dev->driver_type == RC_DRIVER_IR_RAW_TX) { > > Here the if is wrong. It should be > "if (dev->driver_type != RC_DRIVER_IR_RAW_TX)". Note that as result > the decoder thread is not started, so patch 4 won't be needed either. but I need the ir-lirc-codec as it handles the interface with userspace and it calls the tx_ir and s_tx_carrier. if I do "if (dev->driver_type != RC_DRIVER_IR_RAW_TX)" the lirc-codec is not called and I would need to handle it on my driver, but then we fall in the first version of the driver. Thanks, Andi > > if (!raw_init) { > > request_module_nowait("ir-lirc-codec"); > > raw_init = true;