From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754804AbcGUV0h (ORCPT ); Thu, 21 Jul 2016 17:26:37 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:34677 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754380AbcGUV0d (ORCPT ); Thu, 21 Jul 2016 17:26:33 -0400 Date: Thu, 21 Jul 2016 17:26:00 -0400 From: Tejun Heo To: tom.ty89@gmail.com Cc: hare@suse.de, sergei.shtylyov@cogentembedded.com, arnd@arndb.de, sfr@canb.auug.org.au, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Subject: Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page Message-ID: <20160721212600.GF23759@htj.duckdns.org> References: <14bd98eb08ddf86be28f558817bed3cd27c397cd.1469126217.git.tom.ty89@gmail.com> <2ed3f3aba21a4b815e9497e6aeba497280f9f333.1469126217.git.tom.ty89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ed3f3aba21a4b815e9497e6aeba497280f9f333.1469126217.git.tom.ty89@gmail.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 22, 2016 at 02:41:54AM +0800, tom.ty89@gmail.com wrote: > @@ -3854,6 +3852,8 @@ static unsigned int ata_scsi_mode_select_xlat(struct ata_queued_cmd *qc) > if (ata_mselect_control(qc, p, pg_len, &fp) < 0) { > fp += hdr_len + bd_len; > goto invalid_param; > + } else { > + goto skip; /* No ATA command to send */ Hmmm... I'm a bit confused. Why is mselect_control path different from mselect_caching in terms of qc handling? Thanks. -- tejun